Skip to content

fix: shut up mypy #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix: shut up mypy #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
294891c
fix: mypy error in ts_qt
Computerdores Nov 28, 2024
da3f4bd
fix: mypy error in file_opener due to conflicting types
Computerdores Nov 28, 2024
6662cd3
fix: remove unnecessary type ignores
Computerdores Nov 28, 2024
eec1c2f
refix type ignore comments
Computerdores Nov 28, 2024
2815bf0
partially revert "refix type ignore comments" due to being implemente…
Computerdores Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tagstudio/src/qt/helpers/file_opener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ def open_file(path: str | Path, file_manager: bool = False):
normpath = Path(path).resolve().as_posix()
if file_manager:
command_name = "explorer"
command_args = '/select,"' + normpath + '"'
command_arg = '/select,"' + normpath + '"'
# For some reason, if the args are passed in a list, this will error when the
# path has spaces, even while surrounded in double quotes.
subprocess.Popen(
command_name + command_args,
command_name + command_arg,
shell=True,
close_fds=True,
creationflags=subprocess.CREATE_NEW_PROCESS_GROUP
Expand Down
3 changes: 2 additions & 1 deletion tagstudio/src/qt/ts_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def start(self) -> None:

if os.name == "nt":
appid = "cyanvoxel.tagstudio.9"
ctypes.windll.shell32.SetCurrentProcessExplicitAppUserModelID(appid) # type: ignore
ctypes.windll.shell32.SetCurrentProcessExplicitAppUserModelID(appid) # type: ignore[attr-defined,unused-ignore]

if sys.platform != "darwin":
icon = QIcon()
Expand Down Expand Up @@ -823,6 +823,7 @@ def run_macro(self, name: MacroID, grid_idx: int):
if field.type.type == FieldTypeEnum.TEXT_LINE and field.value:
self.lib.update_entry_field(
entry_ids=entry.id,
field=field,
content=strip_web_protocol(field.value),
)

Expand Down