Skip to content

fix: 소셜로그인 방식 수정#135

Merged
heeeeyong merged 3 commits intomainfrom
develop
Aug 17, 2025
Merged

fix: 소셜로그인 방식 수정#135
heeeeyong merged 3 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 17, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

Summary by CodeRabbit

  • 신규 기능: 해당 없음
  • 버그 수정
    • 임시 액세스 토큰 자동 주입을 중단하여 실제 로그인 상태를 정확히 반영합니다. 로그인 쿠키가 없을 경우 요청이 인증되지 않을 수 있으며, 로그인이 필요하다는 안내가 표시될 수 있습니다.
    • 인증 동작의 예측 가능성과 보안을 개선했습니다.
  • 유지보수(Chores)
    • 쿠키 존재 여부에 대한 내부 로깅을 정비하여 문제 진단을 용이하게 했습니다. 사용자의 화면/기능 변화는 없습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

요청 인터셉터에서 Authorization 헤더에 임시 토큰을 주입하던 로직을 비활성화하고, 쿠키 존재 여부만 로그로 남기도록 변경되었습니다. TEMP_ACCESS_TOKEN 사용 경로가 주석 처리되었으며, 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Summary of changes
Auth 인터셉터 로직 비활성화
src/api/index.ts
TEMP_ACCESS_TOKEN 주입 경로 주석 처리, Authorization 쿠키 유무만 로그 출력, 헤더 자동 설정 중단, 주석 추가.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant apiClient
  participant Interceptor
  participant Server

  Client->>apiClient: API 요청
  apiClient->>Interceptor: 요청 인터셉트
  Interceptor->>Interceptor: Authorization 쿠키 존재 확인
  alt 쿠키 있음
    Interceptor-->>apiClient: 헤더 변경 없음 (쿠키 자동 전송)
  else 쿠키 없음
    Interceptor-->>apiClient: 헤더 주입 안 함 (로그만 기록)
  end
  apiClient->>Server: 요청 전송 (브라우저가 쿠키 포함 시 자동 전송)
  Server-->>apiClient: 응답
  apiClient-->>Client: 응답 반환
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

  • [API] auth API 연동 #73: src/api/index.ts에서 TEMP_ACCESS_TOKEN 헤더 주입을 비활성화하는 동일 주제 변경과 직접 연관.

Possibly related PRs

Suggested labels

🐞 BugFix

Poem

토끼는 수풀에 귀를 세워,
임시 열쇠는 주머니에 넣어 두고,
쿠키 소식만 조용히 듣는다. 🍪
헤더는 가만, 바람도 숨죽이고,
오늘의 요청은 제 길로 간다.
깡총, 로그 한 줄 남기고 끝!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c89a5d5 and 650e9c2.

📒 Files selected for processing (1)
  • src/api/index.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Aug 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 17, 2025 5:31am

@heeeeyong heeeeyong merged commit 79cd0c7 into main Aug 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant