Skip to content

fix: 소셜로그인 방식 수정#134

Merged
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates
Aug 17, 2025
Merged

fix: 소셜로그인 방식 수정#134
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 17, 2025

이하동일

Summary by CodeRabbit

  • 새로운 기능

    • 없음
  • 리팩터링

    • 인증 요청 처리를 단순화하여 브라우저 세션 쿠키에만 의존하도록 조정했습니다. 자동 헤더 추가 동작을 제거했습니다. 사용자 인터페이스 변경은 없습니다.
  • 자잘한 작업

    • 사용되지 않는 임시 토큰 관련 설정을 정리했습니다.
  • 알려진 변경 사항

    • 세션 쿠키가 없을 경우 인증이 필요할 수 있습니다.

@vercel
Copy link

vercel bot commented Aug 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 17, 2025 5:30am

@coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

요청 인터셉터에서 Authorization 헤더 자동 주입 로직을 주석 처리하여 비활성화했고, 쿠키 존재 여부만 로깅하도록 변경했습니다. TEMP_ACCESS_TOKEN도 주석 처리되었습니다. 응답 인터셉터(401 리다이렉트)는 기존과 동일하게 주석 상태입니다. 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Summary
API 요청 인터셉터 단순화
src/api/index.ts
TEMP_ACCESS_TOKEN 주석 처리. Authorization 쿠키가 없을 때 Bearer 토큰을 헤더에 주입하던 로직을 전부 주석 처리. 이제 요청 인터셉터는 쿠키 존재 여부만 로깅하고 헤더를 수정하지 않음. 응답 인터셉터(401 처리)는 변화 없음(주석 유지).

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant apiClient
  participant RequestInterceptor
  participant Server

  Client->>apiClient: API 호출
  apiClient->>RequestInterceptor: 요청 인터셉트
  alt Authorization 쿠키 존재
    RequestInterceptor->>RequestInterceptor: 로그: 쿠키 존재
    Note right of RequestInterceptor: 헤더 수정 없음
  else 쿠키 없음
    RequestInterceptor->>RequestInterceptor: 로그: 쿠키 없음
    Note right of RequestInterceptor: 헤더 수정 없음 (토큰 주입 비활성)
  end
  RequestInterceptor->>Server: 원본 요청 전달(헤더 변경 없음)
  Server-->>apiClient: 응답
  apiClient-->>Client: 응답 반환
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🐞 BugFix

Poem

꼬마 토끼, 주머니 닫고 뛰어가네 —
임시 열쇠는 살짝 묻어두고, 쿠키만 살펴보네.
“헤더는 손대지 말자!” 깡충깡충 메모 남기고,
요청은 가볍게, 길은 더 단순하게.
밤하늘에 로그 별 반짝, 🌟 오늘도 깔끔한 발자국.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 82773d3 and 66634b3.

📒 Files selected for processing (1)
  • src/api/index.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/minor-updates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong merged commit 650e9c2 into develop Aug 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant