Conversation
연동에 따른 로직 변경
searchBooks -> getSearchBooks
Merge pull request #113 from THIP-TextHip/develop
fix: 헤더 임시 하드토큰 반영 로직 추가
feat: books 도메인 API 연동
feat: 새 글 작성을 위한 화면 조회(카테고리, 태그 조회) API 연동
feat: API 연동에 따른 page별 이동 이벤트 구현
fix: Rooms API 복구
fix: carousel 로직 복구
fix: 회원가입 튜토리얼 페이지 추가
fix: 내 프로필, 다른 사용자 프로필 클릭 시 분기 처리
fix: 회원가입 request body에 isTokenRequired 추가
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Walkthrough다수의 신규 API 모듈을 추가하고 기존 페이지/컴포넌트를 모킹 데이터에서 서버 연동 구조로 전환했습니다. 그룹/도서/메모리/피드/최근검색 도메인에 타입 정의와 변환 유틸을 도입하고, 라우팅을 파라미터 기반으로 재구성했으며, 일부 UI/스타일과 훅(인터셉터/캐러셀/토큰) 동작을 갱신했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as SearchBook Page
participant BooksAPI as getBookDetail
participant RoomsAPI as getRecruitingRooms
participant SaveAPI as postSaveBook
UI->>BooksAPI: GET /books/{isbn}
UI->>RoomsAPI: GET /books/{isbn}/recruiting-rooms
BooksAPI-->>UI: BookDetail
RoomsAPI-->>UI: RecruitingRoomsData
UI->>SaveAPI: POST /books/{isbn}/saved { type: !isSaved }
SaveAPI-->>UI: { isSaved }
sequenceDiagram
participant UI as GroupDetail
participant Detail as getRoomDetail
participant Join as postJoinRoom
participant Close as postCloseRoom
UI->>Detail: GET /rooms/{roomId}/recruiting
Detail-->>UI: RoomDetail
alt Host closes
UI->>Close: POST /rooms/{roomId}/close
Close-->>UI: { roomId }
else Join/Cancel
UI->>Join: POST /rooms/{roomId}/join { type }
Join-->>UI: { roomId, type }
end
sequenceDiagram
participant UI as Memory Page
participant List as getMemoryPosts
participant CreateRec as createRecord
participant CreateVote as createVote
participant DelRec as deleteRecord
participant DelVote as deleteVote
UI->>List: GET /rooms/{roomId}/posts?params
List-->>UI: Posts
UI->>CreateRec: POST /rooms/{roomId}/record { page,isOverview,content }
CreateRec-->>UI: { recordId,roomId }
UI->>CreateVote: POST /rooms/{roomId}/vote { page,isOverview,content,items }
CreateVote-->>UI: { voteId,roomId }
UI->>DelRec: DELETE /rooms/{roomId}/record/{recordId}
UI->>DelVote: DELETE /rooms/{roomId}/vote/{voteId}
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
heeeeyong
added a commit
that referenced
this pull request
Aug 17, 2025
Merge pull request #132 from THIP-TextHip/develop
This was referenced Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이하동일
Summary by CodeRabbit
New Features
Improvements
UI/Style