Skip to content

fix: 회원가입 request body에 isTokenRequired 추가#131

Merged
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates
Aug 17, 2025
Merged

fix: 회원가입 request body에 isTokenRequired 추가#131
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 17, 2025

이하동일

Summary by CodeRabbit

  • 신규 기능
    • 회원가입 요청에 “토큰 필요 여부” 옵션이 추가되어 확장된 가입 요청을 지원합니다.
  • 기타 작업
    • 가입 화면에서 새 옵션을 기본적으로 필요 없음으로 전송하도록 요청 데이터를 업데이트했습니다.
    • 사용자 입장에서는 화면과 흐름에 변화 없이 기존과 동일하게 가입이 진행됩니다.

@vercel
Copy link

vercel bot commented Aug 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 17, 2025 5:11am

@coderabbitai
Copy link

coderabbitai bot commented Aug 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

회원가입 요청 타입(PostSignupRequest)에 필수 필드 isTokenRequired:boolean을 추가했고, SignupGenre에서 postSignup 호출 시 해당 필드를 false로 포함하도록 요청 페이로드를 확장했습니다. 응답 타입과 함수 로직, 에러 처리 및 네비게이션 흐름은 변경 없습니다.

Changes

Cohort / File(s) Summary
API 타입 확장
src/api/users/postSignup.ts
PostSignupRequest에 isTokenRequired: boolean 필드 추가. PostSignupResponse와 함수 로직 변경 없음.
회원가입 페이지 호출 업데이트
src/pages/signup/SignupGenre.tsx
postSignup 호출 페이로드에 isTokenRequired: false 추가. 기존 aliasName, nickname 전송 및 성공/에러 흐름 유지.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🐞 BugFix

Suggested reviewers

  • ho0010

Poem

초원 위 깡총깡총 코드토끼 춤추네
새 필드 톡— isTokenRequired, 준비 끝!
페이로드 채우고, 가입길은 그대로
false 한 스푼, 버그는 빼꼼 도망가고
오늘도 빌드 OK! (≧◡≦) 🥕

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b00af3 and c692d12.

📒 Files selected for processing (2)
  • src/api/users/postSignup.ts (1 hunks)
  • src/pages/signup/SignupGenre.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/minor-updates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong merged commit 995f43d into develop Aug 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant