Skip to content

fix: nickname 변수명 수정#113

Merged
heeeeyong merged 8 commits intomainfrom
develop
Aug 13, 2025
Merged

fix: nickname 변수명 수정#113
heeeeyong merged 8 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 13, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

Summary by CodeRabbit

  • 신기능
    • 해당 사항 없음
  • 개선/리팩터
    • 회원가입 경로 구조를 단순화하여 단계 전환의 일관성과 안정성을 개선했습니다.
  • 버그 수정
    • 해당 사항 없음
  • 잡무/정리
    • 회원가입 요청에서 닉네임 필드 표기를 통일해 데이터 입력 일관성을 높였습니다.
    • 회원가입 완료 단계로의 전달 값도 동일한 표기로 정리했습니다.

@vercel
Copy link

vercel bot commented Aug 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
thip Ready Preview Comment Aug 13, 2025 5:29pm

@heeeeyong heeeeyong merged commit 87901f6 into main Aug 13, 2025
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

요청 페이로드 필드가 nickName에서 nickname으로 변경되었고, 해당 사용처가 SignupGenre에서 반영되었습니다. 또한 라우팅이 중첩 구조(/signup 내부 인덱스)에서 평면 구조(/signup, /signup/genre)로 수정되었습니다. 다른 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Change Summary
API 요청 스키마 변경
src/api/users/postSignup.ts
PostSignupRequest의 필드 nickNamenickname으로 변경. 다른 공개 선언은 그대로.
라우팅 평면화
src/pages/index.tsx
/signup 중첩 라우트 제거. /signupSignupNickname, /signup/genreSignupGenre로 직접 매핑.
사용처 업데이트
src/pages/signup/SignupGenre.tsx
API 호출 및 네비게이션 상태에서 nickName 사용을 nickname으로 변경. 로직 변경 없음.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant Router as Router
  participant Nick as SignupNickname
  participant Genre as SignupGenre
  participant API as postSignup

  User->>Router: GET /signup
  Router-->>Nick: Render
  User->>Router: Navigate /signup/genre
  Router-->>Genre: Render
  Genre->>API: POST /users/signup { nickname, aliasName, ... }
  API-->>Genre: 200 OK (PostSignupResponse)
  Genre->>Router: Navigate /signupdone (state: { nickname })
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Possibly related PRs

Suggested labels

🐞 BugFix

Suggested reviewers

  • ho0010

Poem

토끼가 톡톡, 키보드 위 춤을 춰요 🐇
nickName은 살짝 웅크리고, nickname이 번쩍!
길도 펴졌지요—/signup, /signup/genre로 쭉—
장난 같던 미로가 직선이 되었네요.
콩닥콩닥, 가입 완료로 폴짝!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 489633e and 40fedfa.

📒 Files selected for processing (3)
  • src/api/users/postSignup.ts (1 hunks)
  • src/pages/index.tsx (2 hunks)
  • src/pages/signup/SignupGenre.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

heeeeyong added a commit that referenced this pull request Aug 13, 2025
Merge pull request #113 from THIP-TextHip/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant