feat: handle git repositories in remote HPC sessions #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #983. _Feature branch_
This changes the k8s resource name for sessions to be `HpcAmaltheaSession`. It is done to allow for experimenting with the session CRD without impacting parallel work on sessions. This commit should be removed or reverted before the feature PR #984 is merged.
This change adds a new `location` field on the Amalthea session CRD which has two accepted values:
* `local`: the interactive session process runs inside the session pod
* `remote`: the interactive session process runs remotely and is controlled from the session pod
Remote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the `location` field is added, no further change is contained here.
* experimental: remote sessions * update * fix types * error formatting * remove 'not implemented error' * exp: use a dev name for sessions * update * fix e2e? * revert non-important changes * rerun some make targets * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * exp: use a dev name for sessions * more updates * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: install wstunnel in sidecars * feat: add tunnel using wstunnel and os.exec.Command * feat: add tunnel command to sidecars * feat: basic testing of tunnel in sidecars * refactor: use TARGETOS and TARGETARCH instead of WSTUNNEL_PLATFORM * update * fix e2e? * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * Revert chartpress e2e leftovers --------- Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Closes #983. _Feature branch_
This changes the k8s resource name for sessions to be `HpcAmaltheaSession`. It is done to allow for experimenting with the session CRD without impacting parallel work on sessions. This commit should be removed or reverted before the feature PR #984 is merged.
This change adds a new `location` field on the Amalthea session CRD which has two accepted values:
* `local`: the interactive session process runs inside the session pod
* `remote`: the interactive session process runs remotely and is controlled from the session pod
Remote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the `location` field is added, no further change is contained here.
* experimental: remote sessions * update * fix types * error formatting * remove 'not implemented error' * exp: use a dev name for sessions * update * fix e2e? * revert non-important changes * rerun some make targets * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * exp: use a dev name for sessions * more updates * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: install wstunnel in sidecars * feat: add tunnel using wstunnel and os.exec.Command * feat: add tunnel command to sidecars * feat: basic testing of tunnel in sidecars * refactor: use TARGETOS and TARGETARCH instead of WSTUNNEL_PLATFORM * update * fix e2e? * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * Revert chartpress e2e leftovers --------- Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Add the remote session controller sidecar command and start it in the amalthea session.
Runs the tunnel container in remote sessions and setup the HPC job to connect to it. This allows remote HPC sessions to start and have their frontend accessible. Co-authored-by: Salim Kayal <salim.kayal@idiap.ch>
leafty
force-pushed
the
build/support-remote-sessions-hpc
branch
from
4070212 to
2eea81e
Compare
…c' into leafty/git-repositories
leafty
force-pushed
the
build/support-remote-sessions-hpc
branch
from
2eea81e to
a87a3cb
Compare
…c' into leafty/git-repositories
SalimKayal
requested changes
Oct 1, 2025
Collaborator
SalimKayal
left a comment
SalimKayal
left a comment
There was a problem hiding this comment.
Just a small nitpick
SalimKayal
approved these changes
Oct 2, 2025
olevski
requested changes
Oct 2, 2025
Member
olevski
left a comment
olevski
left a comment
There was a problem hiding this comment.
Thanks Flora. A few suggestions.
olevski
approved these changes
Oct 3, 2025
leafty
merged commit e6fd0d9
into
build/support-remote-sessions-hpc
17 of 20 checks passed
leafty
added a commit
that referenced
this pull request
Oct 8, 2025
Handles git repositories for remote sessions. 1. The git repositories are collected in the remote session controller from the `RENKU_WORKING_DIR` folder 2. The git repositories are configured in the remote session job --------- Co-authored-by: Salim Kayal <salim.kayal@idiap.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles git repositories for remote sessions.
RENKU_WORKING_DIRfolderPR stack: