feat: Integrate wstunnel for future remote session ingress #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalimKayal
changed the title
leafty
force-pushed
the
leafty/exp-remote-sessions
branch
from
661e73a to
7d399fa
Compare
SalimKayal
force-pushed
the
salimkayal/wstunnel-sidecar
branch
from
8a9d502 to
3b33b7a
Compare
leafty
force-pushed
the
leafty/exp-remote-sessions
branch
from
518ba1c to
e00de68
Compare
This was referenced Sep 3, 2025
Member
|
I've made this work on staging.dev.renku.ch, so we can rebase this and merge it into the feature branch. |
SalimKayal
force-pushed
the
salimkayal/wstunnel-sidecar
branch
from
9ac5a34 to
e640377
Compare
Collaborator
Author
|
rebased |
Base automatically changed from
leafty/exp-remote-sessions
to
build/support-remote-sessions-hpc
September 8, 2025 07:20
leafty
approved these changes
Sep 8, 2025
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
LGTM.
I'll check the merge conflict.
SalimKayal
merged commit e909a51
into
build/support-remote-sessions-hpc
18 checks passed
leafty
added a commit
that referenced
this pull request
Sep 30, 2025
* experimental: remote sessions * update * fix types * error formatting * remove 'not implemented error' * exp: use a dev name for sessions * update * fix e2e? * revert non-important changes * rerun some make targets * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * exp: use a dev name for sessions * more updates * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: install wstunnel in sidecars * feat: add tunnel using wstunnel and os.exec.Command * feat: add tunnel command to sidecars * feat: basic testing of tunnel in sidecars * refactor: use TARGETOS and TARGETARCH instead of WSTUNNEL_PLATFORM * update * fix e2e? * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * Revert chartpress e2e leftovers --------- Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
leafty
added a commit
that referenced
this pull request
Sep 30, 2025
* experimental: remote sessions * update * fix types * error formatting * remove 'not implemented error' * exp: use a dev name for sessions * update * fix e2e? * revert non-important changes * rerun some make targets * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * exp: use a dev name for sessions * more updates * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: install wstunnel in sidecars * feat: add tunnel using wstunnel and os.exec.Command * feat: add tunnel command to sidecars * feat: basic testing of tunnel in sidecars * refactor: use TARGETOS and TARGETARCH instead of WSTUNNEL_PLATFORM * update * fix e2e? * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * Revert chartpress e2e leftovers --------- Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
leafty
added a commit
that referenced
this pull request
Oct 8, 2025
* experimental: remote sessions * update * fix types * error formatting * remove 'not implemented error' * exp: use a dev name for sessions * update * fix e2e? * revert non-important changes * rerun some make targets * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * exp: use a dev name for sessions * more updates * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: install wstunnel in sidecars * feat: add tunnel using wstunnel and os.exec.Command * feat: add tunnel command to sidecars * feat: basic testing of tunnel in sidecars * refactor: use TARGETOS and TARGETARCH instead of WSTUNNEL_PLATFORM * update * fix e2e? * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * feat: support remote sessions on HPC clusters Closes #983. _Feature branch_ * Revert chartpress e2e leftovers --------- Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging into #984.
This PR integrates
wstunnelinto thesidecarsimage, laying the groundwork for enabling inbound tunnels for Amalthea's remote sessions. This component will allow for more robust and flexible connectivity to remote development environments in a subsequent phase.Key changes in this PR include:
wstunnelBinary Inclusion: Thewstunnelbinary (version 10.4.4 for linux_amd64) is now downloaded and installed within thesidecars.Dockerfile.tunnelCommand: A newtunnelCobra command with alistensubcommand has been added. This command encapsulates the logic for running thewstunnelserver and includes configurable options for thewstunnelsecret, port, and log level, exposed via persistent flags and environment variables.Important Note: This PR focuses solely on packaging
wstunnelas a sidecar and providing the necessary command-line interface within thesidecarsimage. The orchestration and activation of thiswstunnelsidecar from the main Amalthea application are not included in this PR and will be addressed in a future, separate PR. This separation allows for incremental deployment and testing of thewstunnelcomponent.PR stack: