-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add location field to amalthea sessions #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leafty
merged 5 commits into
build/support-remote-sessions-hpc
from
leafty/exp-remote-sessions
Sep 8, 2025
Merged
feat: add location field to amalthea sessions #985
leafty
merged 5 commits into
build/support-remote-sessions-hpc
from
leafty/exp-remote-sessions
Sep 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80292df to
4a51321
Compare
Contributor
|
You can access the deployment of this PR at https://renku-ci-am-985.dev.renku.ch |
7f8c13a to
d87fe48
Compare
661e73a to
7d399fa
Compare
Base automatically changed from
leafty/exp-dev-naming
to
build/support-remote-sessions-hpc
September 2, 2025 12:09
518ba1c to
e00de68
Compare
This was referenced Sep 3, 2025
SalimKayal
approved these changes
Sep 5, 2025
Collaborator
SalimKayal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e74d832
into
build/support-remote-sessions-hpc
44 of 86 checks passed
leafty
added a commit
that referenced
this pull request
Sep 30, 2025
This change adds a new `location` field on the Amalthea session CRD which has two accepted values:
* `local`: the interactive session process runs inside the session pod
* `remote`: the interactive session process runs remotely and is controlled from the session pod
Remote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the `location` field is added, no further change is contained here.
leafty
added a commit
that referenced
this pull request
Sep 30, 2025
This change adds a new `location` field on the Amalthea session CRD which has two accepted values:
* `local`: the interactive session process runs inside the session pod
* `remote`: the interactive session process runs remotely and is controlled from the session pod
Remote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the `location` field is added, no further change is contained here.
leafty
added a commit
that referenced
this pull request
Oct 8, 2025
This change adds a new `location` field on the Amalthea session CRD which has two accepted values:
* `local`: the interactive session process runs inside the session pod
* `remote`: the interactive session process runs remotely and is controlled from the session pod
Remote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the `location` field is added, no further change is contained here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging into #984.
PR stack:
This change adds a new
locationfield on the Amalthea session CRD which has two accepted values:local: the interactive session process runs inside the session podremote: the interactive session process runs remotely and is controlled from the session podRemote sessions are first implemented to support running sessions in HPC environments, though this can be generalized to many environment types.
Only the
locationfield is added, no further change is contained here.For a deployment, see: https://staging.dev.renku.ch.