Merged
Conversation
…sages: - File/directory name can consist of whitespace - Configuration key can consist of whitespace - Logger category name can consist of whitespace - Assembly/type/member name can NOT consist of whitespace - Hostname/url can NOT consist of whitespace - Eureka app-name/instance-ID/VIP-address can NOT consist of whitespace Use ToArray() instead of ToList(), which is slightly more efficient
The following configuration keys are no longer being read, as they were never meant to be: - application:name - application:uris - consul:serviceName - management:name - spring:application:instance_id Renames: - IServiceCollection.RegisterDefaultApplicationInstanceInfo -> AddApplicationInstanceInfo - IServiceCollection.RegisterCloudFoundryApplicationInstanceInfo -> AddCloudFoundryOptions (unified with other extension methods)
…c-comments, make Add*ActuatorServices extension methods internal
…nsafe when used from multiple Steeltoe components)
…ors, unify test contributors into single type
Member
Author
|
/azp run cleanup-code |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run Steeltoe.All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Code cleanup successfully reformatted files, but there were no changes to push. |
TimHess
reviewed
Aug 15, 2024
Member
TimHess
left a comment
TimHess
left a comment
There was a problem hiding this comment.
Looks really good to me, a few questions, comments and minor changes to make
src/Configuration/test/CloudFoundry.Test/CloudFoundryServiceCollectionExtensionsTest.cs
Outdated
Show resolved
Hide resolved
src/Management/src/Endpoint/ThreadDump/EndpointServiceCollectionExtensions.cs
Show resolved
Hide resolved
src/Management/src/Endpoint/SpringBootAdminClient/ConfigureSpringBootAdminClientOptions.cs
Show resolved
Hide resolved
src/Common/src/Common/Configuration/PropertyPlaceHolderHelper.cs
Outdated
Show resolved
Hide resolved
src/Configuration/src/Placeholder/PlaceholderResolverProvider.cs
Outdated
Show resolved
Hide resolved
src/Configuration/src/ConfigServer/ConfigServerConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
5 tasks
5 tasks
bart-vmware
added
the
ReleaseLine/4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Public API review of Steeltoe.Common (first part). See the individual commit messages for details.
Closes #898, closes #897, closes #825, closes #928, closes #916, closes #929, closes #941, closes #946, closes #947, closes #590, closes #962, closes #1257, closes #1271.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.