Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Add some comments #18313

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[Refactor] Add some comments #18313

merged 2 commits into from
Feb 22, 2023

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Feb 22, 2023

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

[Refactor] Add some comments
5e103e4 
Signed-off-by: sduzh <zhuming9011@qq.com>
@sduzh sduzh requested review from wyb, gengjun-git and imay February 22, 2023 11:38
wyb
wyb reviewed Feb 22, 2023
View reviewed changes
gensrc/thrift/PlanNodes.thrift Outdated Show resolved Hide resolved
more comments
514305f 
Signed-off-by: sduzh <zhuming9011@qq.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

ABingHuang
ABingHuang approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ABingHuang ABingHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Feb 22, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@imay imay merged commit 7a1f51f into StarRocks:main Feb 22, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Feb 22, 2023
@sduzh sduzh deleted the refactor/comment branch February 23, 2023 01:49
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Feb 27, 2023
@sduzh @Jay-ju
[Refactor] Add some comments (StarRocks#18313)
28b8204 
Signed-off-by: sduzh <zhuming9011@qq.com>
sduzh added a commit to sduzh/starrocks that referenced this pull request Mar 1, 2023
@sduzh
[Refactor] Add some comments (StarRocks#18313)
4cfbc04 
Signed-off-by: sduzh <zhuming9011@qq.com>
sduzh added a commit that referenced this pull request Mar 2, 2023
@sduzh
[Refactor] Add some comments (#18313) (#18748)
f0ccba9 
Signed-off-by: sduzh <zhuming9011@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@ABingHuang ABingHuang ABingHuang approved these changes

@gengjun-git gengjun-git Awaiting requested review from gengjun-git

@imay imay Awaiting requested review from imay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sduzh @wanpengfei-git @wyb @ABingHuang @imay