Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Add some comments #18313

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[Refactor] Add some comments #18313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e103e4
[Refactor] Add some comments
Feb 22, 2023
514305f
more comments
Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ protected void toThrift(TPlanNode msg) {
if (!olapTable.hasDelete()) {
msg.lake_scan_node.setUnused_output_column_name(unUsedOutputStringColumns);
}
} else {
} else { // If you find yourself changing this code block, see also the above code block, i.e, if (olapTable.isLakeTable) { ... }.
msg.node_type = TPlanNodeType.OLAP_SCAN_NODE;
msg.olap_scan_node =
new TOlapScanNode(desc.getId().asInt(), keyColumnNames, keyColumnTypes, isPreAggregation);
Expand Down
2 changes: 2 additions & 0 deletions gensrc/thrift/PlanNodes.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ struct TSchemaScanNode {
11: optional Types.TUserIdentity current_user_ident // to replace the user and user_ip
}

// If you find yourself changing this struct, see also TLakeScanNode
struct TOlapScanNode {
1: required Types.TTupleId tuple_id
2: required list<string> key_column_name
Expand Down Expand Up @@ -447,6 +448,7 @@ struct TJDBCScanNode {
5: optional i64 limit
}

// If you find yourself changing this struct, see also TOlapScanNode
struct TLakeScanNode {
1: required Types.TTupleId tuple_id
2: required list<string> key_column_name
Expand Down