[Refactor] Add some comments (StarRocks#18313)

Signed-off-by: sduzh <zhuming9011@qq.com>
sduzh · Mar 1, 2023 · 4cfbc04 · 4cfbc04
1 parent bb9d3de
commit 4cfbc04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java b/fe/fe-core/src/main/java/com/starrocks/planner/OlapScanNode.java
@@ -772,7 +772,7 @@ protected void toThrift(TPlanNode msg) {
             if (!olapTable.hasDelete()) {
                 msg.lake_scan_node.setUnused_output_column_name(unUsedOutputStringColumns);
             }
-        } else {
+        } else { // If you find yourself changing this code block, see also the above code block, i.e, if (olapTable.isLakeTable) { ... }.
             msg.node_type = TPlanNodeType.OLAP_SCAN_NODE;
             msg.olap_scan_node =
                     new TOlapScanNode(desc.getId().asInt(), keyColumnNames, keyColumnTypes, isPreAggregation);

diff --git a/gensrc/thrift/PlanNodes.thrift b/gensrc/thrift/PlanNodes.thrift
@@ -424,6 +424,7 @@ struct TSchemaScanNode {
   15: optional i64 txn_id
 }
 
+// If you find yourself changing this struct, see also TLakeScanNode
 struct TOlapScanNode {
   1: required Types.TTupleId tuple_id
   2: required list<string> key_column_name
@@ -451,6 +452,7 @@ struct TJDBCScanNode {
   5: optional i64 limit
 }
 
+// If you find yourself changing this struct, see also TOlapScanNode
 struct TLakeScanNode {
   1: required Types.TTupleId tuple_id
   2: required list<string> key_column_name