Add save to zarr #250
Merged
Add save to zarr #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto add_save_to_zarr
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 88.41% 88.59% +0.17%
==========================================
Files 10 10
Lines 1718 1797 +79
==========================================
+ Hits 1519 1592 +73
- Misses 199 205 +6 ☔ View full report in Codecov by Sentry. |
alejoe91
reviewed
Jan 31, 2024
alejoe91
reviewed
Jan 31, 2024
for more information, see https://pre-commit.ci
|
@samuelgarcia ok to merge for me |
samuelgarcia
reviewed
Feb 2, 2024
|
I am OK with this but why not relying more the the to_numpy() / from numpy() solution to dump by columns reprentation ? |
|
@samuelgarcia I think it would be a good idea to make the representations (numpy, dataframe, zarr) more consistent internally. Can you be more explicit about what do you mean by "dump by columns representation"? |
samuelgarcia
reviewed
Feb 5, 2024
samuelgarcia
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. The probe can be serialized / marshalled to zarr and loaded.
This should come after #249 and #248