Skip to content

Conversation

@h-mayorquin
Copy link
Collaborator

Related to the hybrid project as requested.

@h-mayorquin h-mayorquin added core Changes to core module hybrid Related to Hybrid testing labels Jan 21, 2024
@h-mayorquin h-mayorquin self-assigned this Jan 21, 2024
@yger
Copy link
Collaborator

yger commented Jan 22, 2024

Thanks a lot! Just because I'm also playing with the Templates, with such a PR, will be able to load/save templates as we can currently do with sorting/recordings ? Can we have a save() function that will keep the same syntax as for other objects?

@alejoe91
Copy link
Member

@yger for now let's keep the to_zarr/from_zarr. We can refactor the calls later

@alejoe91 alejoe91 added this to the 0.100.0 milestone Jan 23, 2024
@alejoe91
Copy link
Member

@samuelgarcia ready to merge on my side. Wanna take a look?

@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Jan 31, 2024

@samuelgarcia
Copy link
Member

samuelgarcia commented Jan 31, 2024

Thanks a lot for this this will be usefull.
Amybe we could add also the possibility to give an existing zarr folder and append this temapltes to specific sub group.
We have this in zarr sorting:
https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/core/zarrextractors.py#L176
https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/core/zarrextractors.py#L324

This can be convinient to save templates + other suff.

If you do not have time this is already OK for me. No worry.

@h-mayorquin
Copy link
Collaborator Author

@samuelgarcia totally agree about that.

Let's do it now. In fact, when I was working in the zarr io for probe interface I came to the conclusion that that is the best pattern. In fact, we picked the same name convention and all:

https://github.com/h-mayorquin/probeinterface/blob/39ae4cd6d68f780a4eeefd932bac8aa905bed5c4/src/probeinterface/probe.py#L964-L1042

I am wondering if you guys could check that one quickly in probe interface so I can save the probe to zarr completly instead of saving it as a dict as I do here:

SpikeInterface/probeinterface#250

@h-mayorquin
Copy link
Collaborator Author

@samuelgarcia I added the requested method.

This should be ready save using the zarr machinery developed on the probeinterface side:
SpikeInterface/probeinterface#250

@alejoe91 alejoe91 merged commit bd317fe into SpikeInterface:main Feb 5, 2024
@h-mayorquin h-mayorquin deleted the templates_to_zarr branch May 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Changes to core module hybrid Related to Hybrid testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants