-
Notifications
You must be signed in to change notification settings - Fork 225
zarr IO for templates object #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot! Just because I'm also playing with the Templates, with such a PR, will be able to load/save templates as we can currently do with sorting/recordings ? Can we have a save() function that will keep the same syntax as for other objects? |
|
@yger for now let's keep the |
|
@samuelgarcia ready to merge on my side. Wanna take a look? |
|
Thanks a lot for this this will be usefull. This can be convinient to save templates + other suff. If you do not have time this is already OK for me. No worry. |
|
@samuelgarcia totally agree about that. Let's do it now. In fact, when I was working in the zarr io for probe interface I came to the conclusion that that is the best pattern. In fact, we picked the same name convention and all: I am wondering if you guys could check that one quickly in probe interface so I can save the probe to zarr completly instead of saving it as a dict as I do here: |
|
@samuelgarcia I added the requested method. This should be ready save using the zarr machinery developed on the probeinterface side: |
Related to the hybrid project as requested.