Skip to content

Conversation

@h-mayorquin
Copy link
Collaborator

Will make the diff of #248 easier to read.

@h-mayorquin h-mayorquin requested a review from alejoe91 January 30, 2024 16:00
@h-mayorquin h-mayorquin self-assigned this Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cdf024) 88.41% compared to head (bc23643) 88.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          10       10           
  Lines        1718     1718           
=======================================
  Hits         1519     1519           
  Misses        199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alejoe91
Copy link
Member

@h-mayorquin would this be covered by this #247 ?

@h-mayorquin
Copy link
Collaborator Author

I am actuall not sure.

@alejoe91
Copy link
Member

I think it might, since the pre-commits should do black formatting

@alejoe91
Copy link
Member

Should I merge that first?

hooks:
- id: black
files: ^src/
files: ^src/|^test/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing @alejoe91 you can merge the other one and then this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!

@h-mayorquin h-mayorquin mentioned this pull request Jan 30, 2024
@alejoe91 alejoe91 merged commit ee744f8 into SpikeInterface:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants