Feature/weaviate memory #424

cs0lar · 2023-04-07T21:09:58Z

Background

This change allows the use of different vector-based memories for Auto-GPT as long as the Memory interface is implemented. As an example, this change integrates Weaviate as an alternative to Pinecone that can be instantiated locally.

Changes

We created a providers directory which is meant to hold the various memory implementations.
The original scripts/memory.py file has been moved into the providers module and it declares Memory as an interface to be implemented.
A new scripts/factory.py file has been added which declares a factory method for creating the appropriate memory support class. A new environment variable, MEMORY_PROVIDER allows to configure which provider to use.
The Pinecone implementation has been moved into the providers module.
An Weaviate implementation of the Memory interface has been added.

Test Plan

Added factory tests in tests/memory_tests.py

Change Safety

I have added tests to cover my changes
I have considered potential risks and mitigations for my changes

…tion

…are absent in the latest version of execute_command therefore the corresponding handlers commit_memory, delete_memory and overwrite_memory have been removed also because they assume a memory with a different interface than the proposed one.

cs0lar · 2023-04-08T07:18:03Z

I have noticed that the latest commands list in commands.py no longer supports the memory-related command (memory_del, memory_ovr). In this pull request I have removed the associated handlers (delete_memory and overwrite_memory) as well as the original commit_memory in part because they no longer follow the memory interface. Let me know whether these memory commands should be back on the menu and I can implement them.

dahifi · 2023-04-10T13:14:47Z

Thank you so much I was actually working on a similar branch last week! 😃

cs0lar · 2023-04-11T10:16:29Z

I have now merged the memory strategy from the master branch and added weaviate to the supported providers. I have also added tests for the weaviate integration.

nponeccop

LGTM but needs whitespace fixes.

nponeccop · 2023-04-11T11:59:52Z

README.md

@@ -185,13 +185,15 @@ Pinecone enables the storage of vast amounts of vector-based memory, allowing fo
 2. Choose the `Starter` plan to avoid being charged.
 3. Find your API key and region under the default project in the left sidebar.

+


Revert the unrelated whitespace changes

README.md

nponeccop · 2023-04-11T12:00:58Z

scripts/commands.py

@@ -298,4 +298,4 @@ def delete_agent(key):
    result = agents.delete_agent(key)
    if not result:
        return f"Agent {key} does not exist."
-    return f"Agent {key} deleted."
+    return f"Agent {key} deleted."


This is optional, but add an extra line feed at the end of file to remove this (-) sign from the diff. I will still approve if you won't

scripts/main.py

nponeccop · 2023-04-11T12:04:11Z

scripts/memory/pinecone.py

@@ -1,4 +1,3 @@
-


nponeccop · 2023-04-11T12:04:36Z

scripts/memory/pinecone.py

@@ -48,4 +47,4 @@ def get_relevant(self, data, num_relevant=5):
        return [str(item['metadata']["raw_text"]) for item in sorted_results]

    def get_stats(self):
-        return self.index.describe_index_stats()
+        return self.index.describe_index_stats()


Here you removed the final line feed. Just revert

scripts/memory/weaviate.py

cs0lar · 2023-04-11T12:52:45Z

@nponeccop - applied all requests.

hsm207 · 2023-04-11T21:16:25Z

@cs0lar what are your thoughts on adding support for embedded weaviate too as part of this PR?

Feature/weaviate embedded

cs0lar · 2023-04-12T07:26:27Z

@hsm207 Thanks for spotting that. I have added weaviate embedded support now. Please check it out.

nponeccop · 2023-04-12T08:12:15Z

.env.template

 OPENAI_AZURE_API_BASE=your-base-url-for-azure
 OPENAI_AZURE_API_VERSION=api-version-for-azure
 OPENAI_AZURE_DEPLOYMENT_ID=deployment-id-for-azure
 IMAGE_PROVIDER=dalle
-HUGGINGFACE_API_TOKEN=


Undo the relocation of the HUGGINGFACE line

thanks! there were also some dupes I have now removed.

bobvanluijt · 2023-04-15T15:05:08Z

@bobvanluijt it would be great to know what's holding merging this branch (apart from the latest conflicts).

Thanks, @nponeccop, I think it's the merging of other PRs. Seems we are almost there. Your help is appreciated in keeping this PR up-to-date 🙏

Almost there, it seems: #424 (comment)

BTW honour to @nponeccop for relentlessly checking the PRs and conflict fixes!

Yup, thanks @nponeccop

bobvanluijt · 2023-04-15T16:39:00Z

Awesome! I think the PR can be merged 🥳

hsm207 · 2023-04-13T15:32:47Z

scripts/memory/weaviate.py

+
+    def _build_auth_credentials(self, cfg):
+        if cfg.weaviate_username and cfg.weaviate_password:
+            return weaviate_auth.AuthClientPassword(cfg.weaviate_username, cfg.weaviate_password)


@cs0lar this line will throw an error as weaviate_auth is not defined anymore in this module

Suggested change

return weaviate_auth.AuthClientPassword(cfg.weaviate_username, cfg.weaviate_password)

return weaviate.AuthClientPassword(cfg.weaviate_username, cfg.weaviate_password)

```@cs0lar this line will throw an error as `weaviate_auth` is not defined anymore in this module

@cs0lar I think you missed this change

bobvanluijt · 2023-04-15T18:15:07Z

@cs0lar, I think we need your help again. People on the Auto-GPT Discord are asking for this merge 😂

bobvanluijt · 2023-04-16T06:33:31Z

Hi @nponeccop and @richbeales. I think the merge conflict is resolved. Would be awesome if you could review and merge. Thanks 🙏

richbeales · 2023-04-16T06:48:48Z

Thanks for reaching out @bobvanluijt - we'll get to this shortly. I'll ping you when ready.

level20peon · 2023-04-16T07:18:40Z

I think Milvus and Weaviate should also be appended here, right? https://github.com/Significant-Gravitas/Auto-GPT/blob/master/.env.template#L53

Weaviate integration is mentioned in its own section, but Milvus doesn't have that mention and rather than being scathered all around the config, they should all be neatly gathered at the top (imho).

bobvanluijt · 2023-04-16T07:40:02Z

🎉 thanks all for the help and merge 🎉

Added a minor change here: #1813

Basically, so that people don't have to install the Weaviate client manually.

…ate-memory Feature/weaviate memory

csolar added 2 commits April 7, 2023 20:41

added support for multiple memory provider and added weaviate integra…

986d32c

…tion

added factory tests

da4ba3c

dominikdassow mentioned this pull request Apr 8, 2023

Implement Local Cache and Redis Memory backend #372

Merged

2 tasks

cs0lar added 2 commits April 8, 2023 07:45

Merge branch 'master' into feature/weaviate-memory

1e63bc5

davelm42 mentioned this pull request Apr 8, 2023

Integrate Qdrant In-Memory Storage into LangChain #273

Closed

Bakuutin previously approved these changes Apr 8, 2023

View reviewed changes

resolved conflicts between master and feature/weaviate-memory

97ac802

cs0lar dismissed Bakuutin’s stale review via 97ac802 April 8, 2023 14:38

moved pinecone api config settings into provider class

76a1462

nponeccop previously approved these changes Apr 10, 2023

View reviewed changes

nponeccop mentioned this pull request Apr 10, 2023

PRs batch 2 #673

Closed

1 task

added weaviate to the supported vector memory providers

5fe784a

cs0lar dismissed nponeccop’s stale review via 5fe784a April 11, 2023 10:14

nponeccop suggested changes Apr 11, 2023

View reviewed changes

csolar added 2 commits April 11, 2023 13:50

fixed formatting

786ee60

fixed formatting

3c7767f

nponeccop previously approved these changes Apr 11, 2023

View reviewed changes

nponeccop mentioned this pull request Apr 11, 2023

PR batch 3 #709

Closed

1 task

cs0lar and others added 3 commits April 12, 2023 05:40

added support for weaviate embedded

96c5e92

added support for weaviate embedded

453b428

Merge pull request #1 from cs0lar/feature/weaviate-embedded

75c4132

Feature/weaviate embedded

cs0lar dismissed nponeccop’s stale review via 75c4132 April 12, 2023 07:24

nponeccop suggested changes Apr 12, 2023

View reviewed changes

nponeccop previously approved these changes Apr 15, 2023

View reviewed changes

hsm207 suggested changes Apr 15, 2023

View reviewed changes

fixed change request

8916b76

cs0lar dismissed nponeccop’s stale review via 8916b76 April 15, 2023 17:53

fixed auth code

899c815

hsm207 previously approved these changes Apr 15, 2023

View reviewed changes

fixed merge conflicts

5122422

cs0lar dismissed hsm207’s stale review via 5122422 April 15, 2023 19:32

merged master and resolved conflicts

03d2032

richbeales added the potential plugin This may fit better into our plugin system. label Apr 16, 2023

cs0lar and others added 2 commits April 16, 2023 07:49

merged master and resolved conflicts

23b89b8

Update requirements.txt

4cd412c

BillSchumacher previously approved these changes Apr 16, 2023

View reviewed changes

Merge branch 'master' into feature/weaviate-memory

37a1dc1

BillSchumacher dismissed their stale review via 37a1dc1 April 16, 2023 07:05

richbeales previously approved these changes Apr 16, 2023

View reviewed changes

Fix README

b865e2c

BillSchumacher dismissed richbeales’s stale review via b865e2c April 16, 2023 07:08

BillSchumacher approved these changes Apr 16, 2023

View reviewed changes

BillSchumacher merged commit ad4c3e0 into Significant-Gravitas:master Apr 16, 2023

cs0lar deleted the feature/weaviate-memory branch April 16, 2023 07:10

sadmuphin mentioned this pull request Apr 16, 2023

Fixed new backends not being added to supported memory #1977

Merged

5 tasks

sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024

Merge pull request Significant-Gravitas#424 from cs0lar/feature/weavi…

f36f08a

…ate-memory Feature/weaviate memory

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/weaviate memory #424

Feature/weaviate memory #424

cs0lar commented Apr 7, 2023

cs0lar commented Apr 8, 2023 •

edited

Loading

dahifi commented Apr 10, 2023

cs0lar commented Apr 11, 2023

nponeccop left a comment

nponeccop Apr 11, 2023

nponeccop Apr 11, 2023

nponeccop Apr 11, 2023

nponeccop Apr 11, 2023

cs0lar commented Apr 11, 2023

hsm207 commented Apr 11, 2023

cs0lar commented Apr 12, 2023

nponeccop Apr 12, 2023

cs0lar Apr 12, 2023

bobvanluijt commented Apr 15, 2023

bobvanluijt commented Apr 15, 2023

hsm207 Apr 13, 2023

hsm207 Apr 13, 2023

hsm207 Apr 15, 2023

bobvanluijt commented Apr 15, 2023

bobvanluijt commented Apr 16, 2023

richbeales commented Apr 16, 2023

level20peon commented Apr 16, 2023 •

edited

Loading

bobvanluijt commented Apr 16, 2023

		@@ -185,13 +185,15 @@ Pinecone enables the storage of vast amounts of vector-based memory, allowing fo
		2. Choose the `Starter` plan to avoid being charged.
		3. Find your API key and region under the default project in the left sidebar.

	return weaviate_auth.AuthClientPassword(cfg.weaviate_username, cfg.weaviate_password)
	return weaviate.AuthClientPassword(cfg.weaviate_username, cfg.weaviate_password)
	```@cs0lar this line will throw an error as `weaviate_auth` is not defined anymore in this module

Feature/weaviate memory #424

Feature/weaviate memory #424

Conversation

cs0lar commented Apr 7, 2023

Background

Changes

Test Plan

Change Safety

cs0lar commented Apr 8, 2023 • edited Loading

dahifi commented Apr 10, 2023

cs0lar commented Apr 11, 2023

nponeccop left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cs0lar commented Apr 11, 2023

hsm207 commented Apr 11, 2023

cs0lar commented Apr 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bobvanluijt commented Apr 15, 2023

bobvanluijt commented Apr 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bobvanluijt commented Apr 15, 2023

bobvanluijt commented Apr 16, 2023

richbeales commented Apr 16, 2023

level20peon commented Apr 16, 2023 • edited Loading

bobvanluijt commented Apr 16, 2023

cs0lar commented Apr 8, 2023 •

edited

Loading

level20peon commented Apr 16, 2023 •

edited

Loading