Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Weaviate client to the requirements.txt file #1813

Closed
wants to merge 1 commit into from

Conversation

bobvanluijt
Copy link
Contributor

Background

To use the Weaviate backend, people need to manually install the Python client. Added it to requirements.txt to fix this.

Changes

Added Weaviate to requirements.txt

Documentation

n.a.

Test Plan

Validated that the complete requirements.txt file is correct

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@BillSchumacher
Copy link
Contributor

If they want to use Weaviate they can install it separately. That's why we have try except ImportErrors on all memory backends.

@bobvanluijt bobvanluijt mentioned this pull request Apr 16, 2023
2 tasks
@bobvanluijt
Copy link
Contributor Author

That's why we have try except ImportErrors on all memory backends.

@BillSchumacher Aha, apologies; I wasn't aware this was a design choice.

Would you suggest adding it to the readme to avoid confusion? Or just let it throw the error?

@bobvanluijt
Copy link
Contributor Author

Additionally, I noticed that some backends are in the requirements.txt file, hence the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants