Add printHidden prop to Box #7978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
box_add-print-hidden
branch
from
489f96a to
7278272
Compare
kyledurand
force-pushed
the
box_add-print-hidden
branch
from
7278272 to
5a99c11
Compare
kyledurand
commented
Jan 3, 2023
|
|
||
| .printHidden { | ||
| @media print { | ||
| // stylelint-disable-next-line -- necessary display property with !important |
Member
Author
There was a problem hiding this comment.
Is this an ok description? I'm not really sure what to do with these comments if we can't copy them
Contributor
There was a problem hiding this comment.
Yes I think that makes sense
Contributor
size-limit report 📦
|
aveline
approved these changes
Jan 3, 2023
|
|
||
| .printHidden { | ||
| @media print { | ||
| // stylelint-disable-next-line -- necessary display property with !important |
Contributor
There was a problem hiding this comment.
Yes I think that makes sense
Merged
aveline
pushed a commit
that referenced
this pull request
Jan 4, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.17.0 ### Minor Changes - [#7408](#7408) [`7ffd87f7d`](7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Added support for `fieldset` element to `AlphaStack` - [#7978](#7978) [`fb0ed3805`](fb0ed38) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `printHidden` prop to `Box` - [#7408](#7408) [`7ffd87f7d`](7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Banner` component to use new layout primitives - [#7408](#7408) [`7ffd87f7d`](7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `Modal` and its children components to use layout primitives - [#7963](#7963) [`f94cf1496`](f94cf14) Thanks [@aveline](https://github.com/aveline)! - Updated `AlphaStack` docs for `align` prop - [#7408](#7408) [`7ffd87f7d`](7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `AccountConnection` to use new layout primitives - [#7915](#7915) [`81fd3fd5b`](81fd3fd) Thanks [@melaniedamilig](https://github.com/melaniedamilig)! - - Added the `onAnimationEnd` prop to `Collapsible` - Fixed a bug in `Filters` where focus was moved to collapsed filter contents before the `Collapsible` animation ended - [#7956](#7956) [`30cdd2e23`](30cdd2e) Thanks [@aveline](https://github.com/aveline)! - Updated `Box` allowable aria roles - [#7939](#7939) [`8b31e3983`](8b31e39) Thanks [@acidio](https://github.com/acidio)! - Added support for `spacing` prop to List component allowing for a more compact list ### Patch Changes - [#7925](#7925) [`4e33e1ced`](4e33e1c) Thanks [@jas7457](https://github.com/jas7457)! - Updated `IndexTable` and `ProgressBar` to no longer log errors about deprecated `React.findDOMNode` ## @shopify/plugin-polaris@0.0.23 ### Patch Changes - Updated dependencies \[[`bfb537780`](bfb5377)]: - @shopify/polaris-migrator@0.10.2 ## @shopify/polaris-migrator@0.10.2 ### Patch Changes - [#7979](#7979) [`bfb537780`](bfb5377) Thanks [@samrose3](https://github.com/samrose3)! - Early exit if target function isn't present for the scss-replace-duration and scss-replace-easing migrations - Updated dependencies \[[`af0ceb8c6`](af0ceb8), [`e7712e7a5`](e7712e7)]: - @shopify/stylelint-polaris@5.0.2 ## @shopify/stylelint-polaris@5.0.2 ### Patch Changes - [#7954](#7954) [`af0ceb8c6`](af0ceb8) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Use RegExp pattern to exclude reporting invalid scope disables and address memory issues - [#7919](#7919) [`e7712e7a5`](e7712e7) Thanks [@qt314](https://github.com/qt314)! - Deduped converage rules that were in multiple categories ## polaris.shopify.com@0.28.0 ### Minor Changes - [#7963](#7963) [`f94cf1496`](f94cf14) Thanks [@aveline](https://github.com/aveline)! - Updated `AlphaStack` docs for `align` prop ### Patch Changes - [#7921](#7921) [`502530597`](5025305) Thanks [@martenbjork](https://github.com/martenbjork)! - Fixed border radius of component images in the overview page. - Updated dependencies \[[`7ffd87f7d`](7ffd87f), [`fb0ed3805`](fb0ed38), [`7ffd87f7d`](7ffd87f), [`7ffd87f7d`](7ffd87f), [`f94cf1496`](f94cf14), [`4e33e1ced`](4e33e1c), [`7ffd87f7d`](7ffd87f), [`81fd3fd5b`](81fd3fd), [`30cdd2e23`](30cdd2e), [`8b31e3983`](8b31e39)]: - @shopify/polaris@10.17.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kyledurand
added a commit
that referenced
this pull request
Jan 5, 2023
We already have `visuallyHidden` so I think it makes sense to also add `printHidden`. This will unblock some of #7929
This was referenced Jan 6, 2023
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
We already have `visuallyHidden` so I think it makes sense to also add `printHidden`. This will unblock some of Shopify#7929
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.17.0 ### Minor Changes - [Shopify#7408](Shopify#7408) [`7ffd87f7d`](Shopify@7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - - Refactored `ChoiceList` to use primitive Layout components - Added support for `legend` element to `Box` - Added support for `fieldset` element to `AlphaStack` - [Shopify#7978](Shopify#7978) [`fb0ed3805`](Shopify@fb0ed38) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `printHidden` prop to `Box` - [Shopify#7408](Shopify#7408) [`7ffd87f7d`](Shopify@7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Banner` component to use new layout primitives - [Shopify#7408](Shopify#7408) [`7ffd87f7d`](Shopify@7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `Modal` and its children components to use layout primitives - [Shopify#7963](Shopify#7963) [`f94cf1496`](Shopify@f94cf14) Thanks [@aveline](https://github.com/aveline)! - Updated `AlphaStack` docs for `align` prop - [Shopify#7408](Shopify#7408) [`7ffd87f7d`](Shopify@7ffd87f) Thanks [@laurkim](https://github.com/laurkim)! - Refactored `AccountConnection` to use new layout primitives - [Shopify#7915](Shopify#7915) [`81fd3fd5b`](Shopify@81fd3fd) Thanks [@melaniedamilig](https://github.com/melaniedamilig)! - - Added the `onAnimationEnd` prop to `Collapsible` - Fixed a bug in `Filters` where focus was moved to collapsed filter contents before the `Collapsible` animation ended - [Shopify#7956](Shopify#7956) [`30cdd2e23`](Shopify@30cdd2e) Thanks [@aveline](https://github.com/aveline)! - Updated `Box` allowable aria roles - [Shopify#7939](Shopify#7939) [`8b31e3983`](Shopify@8b31e39) Thanks [@acidio](https://github.com/acidio)! - Added support for `spacing` prop to List component allowing for a more compact list ### Patch Changes - [Shopify#7925](Shopify#7925) [`4e33e1ced`](Shopify@4e33e1c) Thanks [@jas7457](https://github.com/jas7457)! - Updated `IndexTable` and `ProgressBar` to no longer log errors about deprecated `React.findDOMNode` ## @shopify/plugin-polaris@0.0.23 ### Patch Changes - Updated dependencies \[[`bfb537780`](Shopify@bfb5377)]: - @shopify/polaris-migrator@0.10.2 ## @shopify/polaris-migrator@0.10.2 ### Patch Changes - [Shopify#7979](Shopify#7979) [`bfb537780`](Shopify@bfb5377) Thanks [@samrose3](https://github.com/samrose3)! - Early exit if target function isn't present for the scss-replace-duration and scss-replace-easing migrations - Updated dependencies \[[`af0ceb8c6`](Shopify@af0ceb8), [`e7712e7a5`](Shopify@e7712e7)]: - @shopify/stylelint-polaris@5.0.2 ## @shopify/stylelint-polaris@5.0.2 ### Patch Changes - [Shopify#7954](Shopify#7954) [`af0ceb8c6`](Shopify@af0ceb8) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Use RegExp pattern to exclude reporting invalid scope disables and address memory issues - [Shopify#7919](Shopify#7919) [`e7712e7a5`](Shopify@e7712e7) Thanks [@qt314](https://github.com/qt314)! - Deduped converage rules that were in multiple categories ## polaris.shopify.com@0.28.0 ### Minor Changes - [Shopify#7963](Shopify#7963) [`f94cf1496`](Shopify@f94cf14) Thanks [@aveline](https://github.com/aveline)! - Updated `AlphaStack` docs for `align` prop ### Patch Changes - [Shopify#7921](Shopify#7921) [`502530597`](Shopify@5025305) Thanks [@martenbjork](https://github.com/martenbjork)! - Fixed border radius of component images in the overview page. - Updated dependencies \[[`7ffd87f7d`](Shopify@7ffd87f), [`fb0ed3805`](Shopify@fb0ed38), [`7ffd87f7d`](Shopify@7ffd87f), [`7ffd87f7d`](Shopify@7ffd87f), [`f94cf1496`](Shopify@f94cf14), [`4e33e1ced`](Shopify@4e33e1c), [`7ffd87f7d`](Shopify@7ffd87f), [`81fd3fd5b`](Shopify@81fd3fd), [`30cdd2e23`](Shopify@30cdd2e), [`8b31e3983`](Shopify@8b31e39)]: - @shopify/polaris@10.17.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
visuallyHiddenso I think it makes sense to also addprintHidden. This will unblock some of #7929