You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[IndexTable, ProgressBar] - stop console.errors being reported about findDOMNode (#7925)
<!--
☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
- Start with a verb, for example: Add, Delete, Improve, Fix…
- Give as much context as necessary and as little as possible
- Prefix it with [WIP] while it’s a work in progress
-->
### WHY are these changes introduced?
While developing in another repo using Polaris, I am getting
console.errors about findDOMNode being deprecated. This is because the
`CSSTransition` component from `react-transition-group` was not being
passed a `nodeRef` properly. This change will properly pass the
`nodeRef` and stop the console.errors.
<!--
Context about the problem that’s being addressed.
-->
### WHAT is this pull request doing?
Passes the correct prop so that CSSTransition will work properly and
React won't complain.
[Without change](https://screenshot.click/15-43-beovu-byqtb.mp4) vs
[with change](https://screenshot.click/15-44-344aj-f0r4h.mp4).
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
<!-- ℹ️ Delete the following for small / trivial changes -->
### How to 🎩
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
<!--
Give as much information as needed to experiment with the component
in the playground.
-->
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- not sure how? the doc just links to cross-browser testing, is this
necessary?
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- N/A
- [ ] Updated the component's `README.md` with documentation changes -
N/A
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide - N/A
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
0 commit comments