Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getNativeScrollRef #1041

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

j-piasecki
Copy link
Contributor

Description

This PR adds implementation for getNativeScrollRef. It's required for compatibility with react-native-reanimated on the new architecture: https://github.com/software-mansion/react-native-reanimated/blob/720fefba7cd53471e98d52282c783701233861a7/src/reanimated2/hook/useAnimatedRef.ts#L26-L33

Reviewers’ hat-rack 🎩

Screenshots or videos (if needed)

Checklist

@j-piasecki
Copy link
Contributor Author

@naqvitalha Can this be merged since the corresponding PR in recyclerlistview has been merged & released, or is anything else blocking this?

github-merge-queue bot pushed a commit to software-mansion/react-native-reanimated that referenced this pull request Jul 9, 2024
## Summary

This PR adds `FlatList` and `FlashList` examples in the example app
showing the usage of the `scrollTo` function. It also mentions the
`FlatList` (yet only this) support in docs.

## Example recordings

| Paper | Fabric |
|-|-|
| <video
src="https://github.com/software-mansion/react-native-reanimated/assets/52978053/2e38a4b0-56fa-4d3e-8ff2-4a1de5d75d62"
/> | <video
src="https://github.com/software-mansion/react-native-reanimated/assets/52978053/813d8b96-304b-4460-8a22-6fcbf722b2ca"
/> |

## Remarks

- `FlashList` supports `scrollTo` only on paper,
- fabric doesn't support it yet.
[This](Shopify/flash-list#1041) PR will fix the
issue.

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@j-piasecki
Copy link
Contributor Author

j-piasecki commented Oct 29, 2024

Hey! @naqvitalha is there a chance to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants