-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollTo examples for FlatList and FlashList #6207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nice work! Got some suggestions though
7222607
to
8e104f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intuitive and clean, like it!
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@tomekzaw Scroll from UI is not working for FlashList. |
Hey @Yusang-park! It looks like they still haven't merged this PR from @j-piasecki which is required for the
public getNativeScrollRef(): React.ElementRef<
typeof ScrollViewComponent
> | null {
return this.rlvRef?.getNativeScrollRef?.() || null;
}
"react-native": "src/index.ts", It will ensure that the FlashList code is read from source files instead of the built js code in the I will ask someone from shopify if we can merge the necessary changes. I hope the next release of the Let me know if it helps. |
Summary
This PR adds
FlatList
andFlashList
examples in the example app showing the usage of thescrollTo
function. It also mentions theFlatList
(yet only this) support in docs.Example recordings
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-04.at.16.21.36.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-04.at.23.35.19.mp4
Remarks
FlashList
supportsscrollTo
only on paper,