Implement getNativeScrollRef
#776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
naqvitalha
reviewed
Mar 15, 2024
| @@ -25,4 +25,9 @@ export default abstract class BaseScrollComponent extends React.Component<Scroll | |||
| public getScrollableNode(): number | null { | |||
| return null; | |||
| } | |||
|
|
|||
| //Override and return ref to your custom scrollview. Useful if you need to use Animated Events on the new architecture. | |||
| public getNativeScrollRef(): unknown | null { | |||
There was a problem hiding this comment.
Does it need to be unknown?
There was a problem hiding this comment.
I don't really remember why I made it this way. Updated to match the type of FlatList.
naqvitalha
previously approved these changes
Jun 10, 2024
ananyachandra14
previously approved these changes
Jun 10, 2024
|
Getting Typescript errors, can you check? @j-piasecki |
j-piasecki
dismissed stale reviews from ananyachandra14 and naqvitalha
via
bd31f4e
|
Now I remember why it was
I solved it by:
|
ananyachandra14
approved these changes
Jun 17, 2024
|
Thanks @j-piasecki! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation for
getNativeScrollRef. It's required for compatibility withreact-native-reanimatedon the new architecture: https://github.com/software-mansion/react-native-reanimated/blob/720fefba7cd53471e98d52282c783701233861a7/src/reanimated2/hook/useAnimatedRef.ts#L26-L33