Skip to content

bitwarden-cli: Persist data#6462

Open
Ra2-IFV wants to merge 1 commit intoScoopInstaller:masterfrom
Ra2-IFV:feat_bitwarden-cli_add-persist
Open

bitwarden-cli: Persist data#6462
Ra2-IFV wants to merge 1 commit intoScoopInstaller:masterfrom
Ra2-IFV:feat_bitwarden-cli_add-persist

Conversation

@Ra2-IFV
Copy link
Copy Markdown
Contributor

@Ra2-IFV Ra2-IFV commented Jan 16, 2025

Reopen for #6219
See bitwarden/cli#117

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 16, 2025

All changes look good.

Wait for review from human collaborators.

bitwarden-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Apr 16, 2025

Will the dir creation make users open a empty database without a migration?

@Ra2-IFV
Copy link
Copy Markdown
Contributor Author

Ra2-IFV commented Apr 17, 2025

Yeah I guess so so I asked if I could write a script to migrate the data

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Apr 17, 2025

If it does NOT cause the database to disappear, memo this change in notes is enought.

@Ra2-IFV
Copy link
Copy Markdown
Contributor Author

Ra2-IFV commented Apr 17, 2025

any examples of telling users how to do that? I'm not good at this

@HUMORCE
Copy link
Copy Markdown
Member

HUMORCE commented Apr 17, 2025

It might look like:

"notes": [
  "The data location has been persisted by Scoop since <version>",
  "Previous location: ...",
  "Current location: ..."
],

for more examples, searching "notes" on main/extras repo via VS Code.

@Ra2-IFV Ra2-IFV force-pushed the feat_bitwarden-cli_add-persist branch from 332c057 to 64fe56a Compare April 17, 2025 12:00
@Ra2-IFV
Copy link
Copy Markdown
Contributor Author

Ra2-IFV commented Apr 17, 2025

Done. Also please take a look at ScoopInstaller/Extras#15311

@jack-mil jack-mil mentioned this pull request Apr 17, 2025
Merged
1 task
HUMORCE
HUMORCE requested changes May 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@HUMORCE HUMORCE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use variables, current version

HUMORCE
HUMORCE reviewed May 25, 2025
View reviewed changes
@Lutra-Fs Lutra-Fs mentioned this pull request May 25, 2025
Open
2 tasks
@Ra2-IFV Ra2-IFV force-pushed the feat_bitwarden-cli_add-persist branch from 64fe56a to ba82e06 Compare May 25, 2025 13:55
@Lutra-Fs Lutra-Fs mentioned this pull request May 28, 2025
Open
2 tasks
This was referenced Aug 13, 2025
Merged
Closed
This was referenced Apr 7, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HUMORCE HUMORCE HUMORCE requested changes

@Lutra-Fs Lutra-Fs Lutra-Fs approved these changes

Assignees

No one assigned

Labels

review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ra2-IFV @HUMORCE @Lutra-Fs