Open
Conversation
2 tasks
Contributor
|
All changes look good. Wait for review from human collaborators. freecad
|
Ra2-IFV
force-pushed
the
feat_freecad_persist
branch
from
2e62a4e to
72bdd1f
Compare
Signed-off-by: Ryan Keane <the.ra2.ifv@gmail.com>
Ra2-IFV
force-pushed
the
feat_freecad_persist
branch
from
72bdd1f to
434b17b
Compare
Contributor
Author
|
PING! |
z-Fng
reviewed
Dec 4, 2025
| "post_install": [ | ||
| "if ($global) { $scope = 'Machine' } else { $scope = 'User' }", | ||
| "if (!$Env:FREECAD_USER_HOME) { [Environment]::SetEnvironmentVariable('FREECAD_USER_HOME', \"$persist_dir\\_userdata\", $scope) }" | ||
| ], | ||
| "bin": "bin\\FreeCADCmd.exe", |
Member
There was a problem hiding this comment.
Will the env_set field work for this case?
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests#optional-properties
env_set: Sets one or more environment variables for the user (or system if --global is used) (example).
Lines 17 to 19 in 7a0aa04
Contributor
Author
There was a problem hiding this comment.
If scoop checks for existing ENV then yes, scoop doesn't do this as far as I know
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<manifest-name[@version]|chore>: <general summary of the pull request>