cherry-studio@1.5.6: Switch Cherry Studio manifest to portable version#16005
cherry-studio@1.5.6: Switch Cherry Studio manifest to portable version#16005GeorgeDong32 wants to merge 231 commits intoScoopInstaller:masterfrom
Conversation
- Switch Cherry Studio manifest to portable version - Add notes and depends - Optimize persist
|
All changes look good. Wait for review from human collaborators. cherry-studio
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. cherry-studio
|
|
Hi here, I am a core developer of Cherry Studio. This PR aims to resolve previously encountered data and dependency issues during Scoop installation. Please let us know of any inaccuracies, and we will promptly address them. |
| "# Handle data directory migration", | ||
| "if (Test-Path \"$persist_dir\\data\") {", | ||
| " $dataItems = Get-ChildItem \"$persist_dir\\data\" -ErrorAction SilentlyContinue", | ||
| " if (-not $dataItems) {", | ||
| " # persist_dir\\data exists but is empty, check if we need to copy from APPDATA", | ||
| " if ((Test-Path \"$env:APPDATA\\CherryStudio\") -and (Get-ChildItem \"$env:APPDATA\\CherryStudio\" -ErrorAction SilentlyContinue)) {", | ||
| " Copy-Item \"$env:APPDATA\\CherryStudio\\*\" \"$persist_dir\\data\" -Recurse -Force", | ||
| " info \"Data copied from '$env:APPDATA\\CherryStudio' to persist directory.\"", | ||
| " }", | ||
| " }", | ||
| "} else {", | ||
| " # persist_dir\\data does not exist", | ||
| " if ((Test-Path \"$env:APPDATA\\CherryStudio\") -and (Get-ChildItem \"$env:APPDATA\\CherryStudio\" -ErrorAction SilentlyContinue)) {", | ||
| " ensure \"$persist_dir\\data\" | Out-Null", | ||
| " Copy-Item \"$env:APPDATA\\CherryStudio\\*\" \"$persist_dir\\data\" -Recurse -Force", | ||
| " info \"Data copied from '$env:APPDATA\\CherryStudio' to persist directory.\"", | ||
| " }", | ||
| "}" |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for your help. Based on the recommendation in ScoopInstaller/Main#6462, as long as this change does not result in data loss or issues for existing users, we should be fine. If user data is preserved and persisted correctly, a clear note in the manifest should be sufficient. So I would recommend you to remove the post_install script.
- Switch Cherry Studio manifest to portable version - Add notes and depends - Optimize persist
…2/Extras into optimize-cherry-manifest
|
/verify |
7 participants
<manifest-name[@version]|chore>: <general summary of the pull request>