Skip to content

Conversation

@patricklnz
Copy link
Member

@patricklnz patricklnz commented Feb 15, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • updated actions in CI to latest releases, as they use node.js 20
  • container image for python wheels was updated

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #937

@patricklnz patricklnz self-assigned this Feb 15, 2024
@patricklnz patricklnz requested review from reneSchm and removed request for reneSchm February 15, 2024 14:23
@patricklnz
Copy link
Member Author

build-py-simulation fails for the latest versions of github actions. I did a workaround that the simulation package still uses the old versions and opened a new Issue #939

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (058b3cc) to head (40b7be7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   96.22%   96.21%   -0.02%     
==========================================
  Files         124      122       -2     
  Lines        9699     9684      -15     
==========================================
- Hits         9333     9317      -16     
- Misses        366      367       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patricklnz patricklnz requested a review from xsaschako March 11, 2024 14:01
@patricklnz patricklnz merged commit aca4b34 into main Mar 13, 2024
@patricklnz patricklnz deleted the 937-update-CI-actions branch March 13, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are depricated

3 participants