Skip to content

Conversation

@dabele
Copy link
Member

@dabele dabele commented Jul 4, 2024

Changes and Information

upgrade manylinux image for python CI. manylinux2014 reached end of life at 30.06.2024, see here

All the other python jobs were updated in #938.
It seems the errors mentioned in #939 were fixed on the side of the image maintainers.

Closes #939

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@dabele dabele self-assigned this Jul 4, 2024
@dabele dabele requested a review from reneSchm July 4, 2024 12:59
@dabele dabele force-pushed the 939-upgrade-manylinux-image-for-python-ci branch from 99cda6b to b445780 Compare July 4, 2024 15:03
@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (3da5874) to head (b445780).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         127      127           
  Lines       10887    10887           
=======================================
  Hits        10478    10478           
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easier than expected.
The issue #939 mentions gcc-toolkit-12 in the log output, so it may or may not have been related to #1060.

@reneSchm
Copy link
Member

reneSchm commented Jul 5, 2024

Next up, we should probably also address the artifact-upload/-download deprecations as well.

@reneSchm reneSchm merged commit 9cf30ee into main Jul 5, 2024
@reneSchm reneSchm deleted the 939-upgrade-manylinux-image-for-python-ci branch July 5, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-py-simulation fails for latest github actions

3 participants