Skip to content

Conversation

@reneSchm
Copy link
Member

@reneSchm reneSchm commented Jun 27, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fix a "use after free" warning with gcc 12.3. and above.

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm added class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. labels Jun 27, 2024
@reneSchm reneSchm self-assigned this Jun 27, 2024
@reneSchm reneSchm requested a review from dabele June 27, 2024 13:29
@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (9ee0b56) to head (3e47105).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         128      128           
  Lines       10867    10868    +1     
=======================================
+ Hits        10458    10459    +1     
  Misses        409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reneSchm reneSchm requested a review from dabele July 2, 2024 07:00
@dabele dabele merged commit 9cd148e into main Jul 3, 2024
@dabele dabele deleted the fix-use-after-free branch July 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants