Skip to content

Make the LCT SECIR model a derived class of CompartmentalModel #914

@lenaploetzke

Description

@lenaploetzke

Motivation / Current Behaviour

Currently the LCT model is not derived from a class. The functionality is similar to the CompartmentalModel.
Also the files memilio/compartments/simulation.h for the CompartmentalModel and models/lct_secir/simulation.h for the LCT model do exactly the same.
Both types of model should be combined.

Enhancement description

It should be no problem to make the LCT SECIR model a derived class of CompartmentalModel to have a consistent project structure.

Additional context

For example: m_initial_values is used exactly like mio::CompartmentalModel::populations. If you want to, you could change its type to mio::Population, make the member public and rename it, so the models have more similar interface.

Originally posted by @reneSchm in #941 (comment)

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project

Metadata

Metadata

Assignees

Labels

class::improvementCleanup that doesn't affect functionalitymodel::lctModels using the linear chain trickmodel::odeThis issue concerns any kind of ODE-based model.prio::moderateThe priority of this task is moderate.

Type

No type

Projects

Status

Done (Total)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions