Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Jun 25, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • LCT model is now a derived class of CompartmentalModel
  • Simulation function of CompartmentalModel is now used instead of separate function
  • LctState works with size_t instead of int

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #914.

@lenaploetzke lenaploetzke added the model::lct Models using the linear chain trick label Jun 25, 2024
@lenaploetzke lenaploetzke self-assigned this Jun 25, 2024
@lenaploetzke lenaploetzke linked an issue Jun 25, 2024 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (9022c7c) to head (349e240).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   96.23%   96.22%   -0.01%     
==========================================
  Files         128      127       -1     
  Lines       10852    10828      -24     
==========================================
- Hits        10443    10419      -24     
  Misses        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested a review from reneSchm June 26, 2024 13:38
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two exceedingly important requests regarding the poor dummy variables. Otherwise, this needs only minor changes, nice work.

@lenaploetzke lenaploetzke requested a review from reneSchm July 1, 2024 14:15
@lenaploetzke lenaploetzke merged commit b131549 into main Jul 2, 2024
@lenaploetzke lenaploetzke deleted the 914-make-the-lct-secir-model-a-derived-class-of-flowmodel branch July 2, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model::lct Models using the linear chain trick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the LCT SECIR model a derived class of CompartmentalModel

3 participants