-
Notifications
You must be signed in to change notification settings - Fork 19
914 make the lct secir model a derived class of flowmodel #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
914 make the lct secir model a derived class of flowmodel #1055
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 96.23% 96.22% -0.01%
==========================================
Files 128 127 -1
Lines 10852 10828 -24
==========================================
- Hits 10443 10419 -24
Misses 409 409 ☔ View full report in Codecov by Sentry. |
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two exceedingly important requests regarding the poor dummy variables. Otherwise, this needs only minor changes, nice work.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #914.