Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 19, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • InfectionState is now a class template and has only static members (variables and functions). More computation is now done at compile time.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #936.

@lenaploetzke lenaploetzke added status::in progress This issue is in progess. class::performance Performance related issues model::lct Models using the linear chain trick labels Feb 19, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 19, 2024
@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (c484b89) to head (3318e28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   96.22%   96.21%   -0.02%     
==========================================
  Files         124      122       -2     
  Lines        9699     9667      -32     
==========================================
- Hits         9333     9301      -32     
  Misses        366      366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke added status::in review This issues is in review. and removed status::in progress This issue is in progess. labels Feb 20, 2024
@lenaploetzke lenaploetzke removed the request for review from reneSchm February 21, 2024 09:37
@lenaploetzke lenaploetzke added status::in progress This issue is in progess. and removed status::in review This issues is in review. labels Feb 21, 2024
@lenaploetzke lenaploetzke added status::in review This issues is in review. prio::high The priority of this task is high. and removed status::in progress This issue is in progess. labels Feb 21, 2024
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great reimplementation of the InfectionState class! There are only a few things that need changing, and optionally some moving/renaming.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is mostly good to go, maybe a few comments/names could be improved.

Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requests resolved, nice work.

@lenaploetzke lenaploetzke merged commit afd4982 into main Mar 1, 2024
@lenaploetzke lenaploetzke deleted the 936-implement-the-class-infectionstate-of-the-lct-model-more-efficiently branch March 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::performance Performance related issues model::lct Models using the linear chain trick prio::high The priority of this task is high. status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the class InfectionState of the LCT model more efficiently

3 participants