-
Notifications
You must be signed in to change notification settings - Fork 19
936 implement the class infectionstate of the lct model more efficiently #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
936 implement the class infectionstate of the lct model more efficiently #941
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 96.22% 96.21% -0.02%
==========================================
Files 124 122 -2
Lines 9699 9667 -32
==========================================
- Hits 9333 9301 -32
Misses 366 366 ☔ View full report in Codecov by Sentry. |
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great reimplementation of the InfectionState class! There are only a few things that need changing, and optionally some moving/renaming.
…e-lct-model-more-efficiently
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is mostly good to go, maybe a few comments/names could be improved.
Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com>
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requests resolved, nice work.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #936.