-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge confirmation pop-up to contacts view and rephrase content [1] #11596
Comments
In the case merge view after closing the warning popup for the fist time and later coming back to the merge view automatically loads the duplicates. Should this behaviour be changed to force the user to confirm the filters to load the duplicates as suggested in the acceptance criteria? I would say not, once accepted and assumed that it will take long time to load the user should not be forced to click on the confirm button. |
I agree with your proposal @leventegal-she |
@leventegal-she No, that's a mistake on my end then - the behaviour should be as in the case merge view, but there should not be any functional changes to the case merge view. |
…merge_load_cofirmation #11596 Add merge confirmation pop-up to contacts view and rephrase co…
I didn't really check the message I assumed it is generic and can be used for both cases and contacts. @abrudanancuta @MateStrysewske is it ok if I change the message to "...reduce the number of rows that have to be compared...." and keep the same message for both pages? |
Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.83.0-SNAPSHOT(3e23ad8). |
Problem Description
At the moment when selecting Merge Case a confirmation pop-up appears informing user that the action can take a long time.
This ticket #9054 introduce a limit that user can use to retrieve the list of merging. Having the pop-up at this moment is also not consistent with Merge Contacts where the pop-up is not in place
Proposed Change
Since the performance issues should largely have been sorted out now, we should still keep the hint (in order to avoid users running into time-outs in situations where the performance is still bad), but change its text. Also, the hint should be added to the contact merge view for consistency reasons.
Updated popup content:
Acceptance Criteria
The text was updated successfully, but these errors were encountered: