Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge confirmation pop-up to contacts view and rephrase content [1] #11596

Closed
3 tasks done
abrudanancuta opened this issue Mar 7, 2023 · 6 comments · Fixed by #11789
Closed
3 tasks done

Add merge confirmation pop-up to contacts view and rephrase content [1] #11596

abrudanancuta opened this issue Mar 7, 2023 · 6 comments · Fixed by #11789
Assignees
Labels
cases change A change of an existing feature (ticket type) qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application

Comments

@abrudanancuta
Copy link
Contributor

abrudanancuta commented Mar 7, 2023

Problem Description

At the moment when selecting Merge Case a confirmation pop-up appears informing user that the action can take a long time.
This ticket #9054 introduce a limit that user can use to retrieve the list of merging. Having the pop-up at this moment is also not consistent with Merge Contacts where the pop-up is not in place
Screenshot 2023-03-07 at 13 49 44

Proposed Change

Since the performance issues should largely have been sorted out now, we should still keep the hint (in order to avoid users running into time-outs in situations where the performance is still bad), but change its text. Also, the hint should be added to the contact merge view for consistency reasons.

Updated popup content:

Calculating and displaying potential duplicates may take a lot of time under specific circumstances. It is recommended to use the filters on top of this view to reduce the number of cases that have to be compared at the same time, e.g. by choosing a narrow creation date interval and a low result count limit. If the potential duplicates are loading fast, extending these values should be safe.

In order to avoid performance issues when entering this view, potential duplicates are only loaded once you click on "Confirm Filters".

Acceptance Criteria

  • The content of the pop-up has been changed to the text specified above
  • The same pop-up is also shown when entering the contact merge view.
    • As in the case merge view, the pop-up is only shown when the user enters the view for the first time during their current session; afterwards it's not displayed anymore, but the user is still required to click on "Confirm filters" before the duplicates are loaded
@abrudanancuta abrudanancuta added the change A change of an existing feature (ticket type) label Mar 7, 2023
@adinaflorea9 adinaflorea9 added cases vaadin-app Affects the Vaadin application labels Mar 7, 2023
@MateStrysewske MateStrysewske changed the title Remove confirmation pop-up when selecting Merge Case Add merge confirmation pop-up to contacts view and rephrase content Mar 29, 2023
@MateStrysewske MateStrysewske added the ready Issue fulfills the definition of ready and can be implemented label Mar 30, 2023
@MateStrysewske MateStrysewske changed the title Add merge confirmation pop-up to contacts view and rephrase content Add merge confirmation pop-up to contacts view and rephrase content [1] Mar 30, 2023
@leventegal-she leventegal-she self-assigned this Apr 3, 2023
@leventegal-she
Copy link
Contributor

As in the case merge view, the pop-up is only shown when the user enters the view for the first time during their current session; afterwards it's not displayed anymore, but the user is still required to click on "Confirm filters" before the duplicates are loaded

In the case merge view after closing the warning popup for the fist time and later coming back to the merge view automatically loads the duplicates. Should this behaviour be changed to force the user to confirm the filters to load the duplicates as suggested in the acceptance criteria?

I would say not, once accepted and assumed that it will take long time to load the user should not be forced to click on the confirm button.

@abrudanancuta @MateStrysewske

@abrudanancuta
Copy link
Contributor Author

I agree with your proposal @leventegal-she

@MateStrysewske
Copy link
Contributor

@leventegal-she No, that's a mistake on my end then - the behaviour should be as in the case merge view, but there should not be any functional changes to the case merge view.

sergiupacurariu added a commit that referenced this issue Apr 6, 2023
…merge_load_cofirmation

#11596 Add merge confirmation pop-up to contacts view and rephrase co…
@adinaflorea9 adinaflorea9 self-assigned this Apr 6, 2023
@adinaflorea9
Copy link

I am reopening the ticket for a small change: the message that is displayed when entering the 'Merge duplicate contacts' view mentions cases instead of contacts:
image

@adinaflorea9 adinaflorea9 reopened this Apr 6, 2023
@leventegal-she
Copy link
Contributor

I didn't really check the message I assumed it is generic and can be used for both cases and contacts.

@abrudanancuta @MateStrysewske is it ok if I change the message to "...reduce the number of rows that have to be compared...." and keep the same message for both pages?

@adinaflorea9
Copy link

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.83.0-SNAPSHOT(3e23ad8).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cases change A change of an existing feature (ticket type) qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
4 participants