forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVMoreMessage] [Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2020-03-30 #8
Open
Descatles
wants to merge
42
commits into
SDKAutoUP:master
Choose a base branch
from
anrudraw:PrivateLink-healthcareapis-Microsoft.HealthcareApis-2020-03-30
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MVMoreMessage] [Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2020-03-30 #8
Descatles
wants to merge
42
commits into
SDKAutoUP:master
from
anrudraw:PrivateLink-healthcareapis-Microsoft.HealthcareApis-2020-03-30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cumulative commit message: commit adaabc1 Author: bganapa <bganapa@microsoft.com> Date: Wed Mar 4 18:07:20 2020 -0800 Changing casing in resourcgroups to resourceGroups commit fb5e9ae Author: bganapa <bganapa@microsoft.com> Date: Wed Feb 26 14:00:37 2020 -0800 Update Readme.md to have $(this-folder)/ for the input-file commit 8234329 Author: bganapa <bganapa@microsoft.com> Date: Sun Feb 9 17:11:33 2020 -0800 Fix-Renaming ResourceGroupParameter to ResourceGroupNameParmameter (Azure#8345) * bug fixes and autorest config addition * Fix path, read-only properties and example * Fix model validation * Suppress camelcase warnings in Activation.json * Suppress RequiredPropertiesMissingInResourceModel * Suppress PathResoourceProviderNamePascalCase * Add default error response * Add 204 response for delete * Remove 404 and add 202 in examples * Fix model validation failures
* added incident entities operation * change example name * change operationId * add format to integer Co-authored-by: Moran Raz Mizrahi <t-momizr@microsoft.com>
* Update readme.md * Update readme.python.md * Update readme.python.md
* [SRP] Introduce 2020-08-01-preview version. * Change versions in example files as well * Introduce list deletedAccounts API. * Fix default error message schema to conform to OData v4 * Address CR comments * Support GetDeletedAccount * prettier * Update readme.azureresourceschema.md Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
…ion stable/2020-10-31 (Azure#10653) * Adds base for updating Microsoft.DigitalTwins from version preview/2020-03-01-preview to version 2020-10-31 * Updates readme * Updates API version in new specs and examples * Aligned descriptions with GA controller models, and regex patterns in parameters * Update nullable attribute to x-nullable * Latest updates * Add x-ms-secret = true for endpoint PUT * Latest changes * Fix reference issue * Simplify operationResults * Update required property name * Update examples * Update provisioning states * Add 200OK response to delete endpoints * Adds suppression to readme * Adds suppression to readme * Fix operation list example * Add additional provisioning state for endpoints * Remove tags from endpoint * Address internal reviewer comments * Update x-ms-secret properties to be nullable * Adds suppression to readme * Update examples with more realistic obfuscated connection strings * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Run npm prettier on changes * Updated readmes
…er namespace (Azure#10710) * Updating readme files to include multi api capability and new namespace * Removing minor addition to cli.md * Revert Csharp changes since multiapi isn't used * Updating PythonSDK namespaces * Removing unnecessary batchapiscript from Python.md * Removing unnecessary package tags Co-authored-by: George Christoglou <gechris@microsoft.com>
* Fix snapshot snapshotPolicyProperties * Fix linter issue, prettier * one more pretty * param in example * remove param in example * Remove whitespace * Remove valiation on readonly properties Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* fix schema * fix schema 2 * remove optional from description * remove required sourceId Co-authored-by: O Yves Chan <oychan@microsoft.com>
* Add new resource to Microsoft.Sql "ServerTrustGroup". * Update sql/readme.md * Add 204 response to ServerTrustGroup DELETE operation. * Fix "prettier check" errors * Fix naming for list by instance name operation.
…e#10766) * added request body for list credential api * Added another example for non aad scenario for list credential api * removed required properties in authentication object * made properties back reqd since body is optional Co-authored-by: Akash Keshari <akkeshar@microsoft.com>
* Update openapi-authoring-automated-guidelines.md * Update openapi-authoring-automated-guidelines.md * Update openapi-authoring-automated-guidelines.md * Update openapi-authoring-automated-guidelines.md
Co-authored-by: Liran Chen <lirche@microsoft.com>
Azure#10791) * Corrected Examples for Resource Mover to generate documentation examples correctly. * Example file name change. * Updates as per Prettier check. * Updates * Model Validation corrections. * Updates Co-authored-by: Ajay Gupta <ajgupt@microsoft.com>
* Add previous API version as baseline. * Add new data plane API version 2020-09-01 * Update management plane with new API 2020-09-01. * Update readme to add new API version. * Fix example errors. * Update comment based on feedback
* Update keys.json * Update keyvault.json
…s should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796)
…ollapsed the reference to metadata. (Azure#10755)
* Add list and get software to GuestConfiguration * Use newer API version for software * Revert software Swagger spec since these are private preview only * Add Automanage resource provider * Address validation tool errors * spelling add antimalware * Address lint errors * Fix error response * Fix newline * Fix Operations API Lint * Fix operations example * Fix prettier and lint * Address lint and prettier errors * Use common definitions and correct pref enum * Fix parameter * Address comments * Fix update examples * Prettier fix * Fix python md * Change provisioningStatus field name * Fix config profile name in examples * resolve conflict * Address conflict Co-authored-by: Abhinav Ghai <abghai@microsoft.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
…A RCM. (Azure#10487) * Update swagger spec with latest V2A-Rcm changes * Fix spell check
…rsion stable/2019-11-01 (Azure#10699) * Created Separate Swagger for Exports * add exports swagger to readme.md
* WIP: Updating Microsoft.AzureData * Minor changes * Adding new SystemData property to examples * Fixed formatting * Update azuredata.json Fixed systemData. * Update azuredata.json Fixed identitytype case. * Fixed formatting * Removing changes from this PR (suggested by ARM). Will send a different PR to rename properties. * Added optional properties to sqlManagedInstances. Removed optional properties from dataControllers. Marked some properties required for dataControllers. * Ran prettier check * Adding missing parameter * Added new definition for data controller patch model * Fixed parameter * Copying 2019 api to 2020 * Removing EOS examples (and list operation which is not supported) * Remvoing EOS stuff from azuredata.json. Removing operation resource as well * Update postgres details * Update postgres example * Updating api-version in examples * Adding last uploaded date and k8sRaw * Update descriptions * Fix paramters * Add missing bracket * Update readme
* updated apispec * spell error fix * removed dncappid from response * updated apispec * Added appid and endpoint in response
…lthcareApis-2020-03-15' to public (Azure#10757)
This was referenced Sep 18, 2020
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Rule | Message |
---|---|
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: CreateKey Scenario: Create key Source: request ResponseCode: ALLMessage: In operation "CreateKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: CreateKey Scenario: Create key Source: request ResponseCode: ALL Message: In operation "CreateKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: ImportKey Scenario: Import key Source: request ResponseCode: ALLMessage: In operation "ImportKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: ImportKey Scenario: Import key Source: request ResponseCode: ALL Message: In operation "ImportKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: DeleteKey Scenario: Delete key Source: request ResponseCode: ALLMessage: In operation "DeleteKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: DeleteKey Scenario: Delete key Source: request ResponseCode: ALL Message: In operation "DeleteKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: UpdateKey Scenario: Update key Source: request ResponseCode: ALLMessage: In operation "UpdateKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: UpdateKey Scenario: Update key Source: request ResponseCode: ALL Message: In operation "UpdateKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: GetKey Scenario: Get key Source: request ResponseCode: ALLMessage: In operation "GetKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: GetKey Scenario: Get key Source: request ResponseCode: ALL Message: In operation "GetKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: GetKeyVersions Scenario: GetKeyVersions Source: request ResponseCode: ALLMessage: In operation "GetKeyVersions", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: GetKeyVersions Scenario: GetKeyVersions Source: request ResponseCode: ALL Message: In operation "GetKeyVersions", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: GetKeys Scenario: GetKeys Source: request ResponseCode: ALLMessage: In operation "GetKeys", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: GetKeys Scenario: GetKeys Source: request ResponseCode: ALL Message: In operation "GetKeys", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: BackupKey Scenario: BackupKey Source: request ResponseCode: ALLMessage: In operation "BackupKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: BackupKey Scenario: BackupKey Source: request ResponseCode: ALL Message: In operation "BackupKey", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: RestoreKey Scenario: RestoreKey Source: request ResponseCode: ALLMessage: In operation "RestoreKey", parameter parameters is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: RestoreKey Scenario: RestoreKey Source: request ResponseCode: ALL Message: In operation "RestoreKey", parameter parameters is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L428 |
[REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND "OperationId: encrypt Scenario: Encrypt example Source: request ResponseCode: ALLMessage: In operation "encrypt", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values.") |
OperationId: encrypt Scenario: Encrypt example Source: request ResponseCode: ALL Message: In operation "encrypt", parameter vaultBaseUrl is required in the swagger spec but is not present in the provided example parameter values. Url: Microsoft.KeyVault/stable/7.0/keyvault.json#L13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror from
https://github.com/Azure/azure-rest-api-specs/pull/10837