Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MVMoreMessage] [Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2020-03-30 #8

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

[MVMoreMessage] [Hub Generated] Review request for Microsoft.HealthcareApis to add version stable/2020-03-30 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
4c0054d
Update batch sdk comments (#10517)
xingwu1 Sep 11, 2020
faf8e1c
Changes for new api version sdk generate (#10685)
yifalu Sep 11, 2020
ff5dc59
[Azure Stack] Updates to Azs.AzureBridge.Admin spec (#9035)
viananth Sep 11, 2020
1c32b72
Connected machine az cli (#10640)
TylerLeonhardt Sep 12, 2020
7a82688
Fix Billing Swagger (#10276)
LianwMS Sep 14, 2020
c008c10
Incident entities (#10648)
moranraz Sep 14, 2020
e52e85b
Update Readmes for Python for Automanage (#10633)
stowen-msft Sep 14, 2020
bd9aa6d
[SRP] Introduce 2020-08-01-preview version. (#10570)
huizlAzure Sep 14, 2020
9092e14
[Hub Generated] Review request for Microsoft.DigitalTwins to add vers…
sjiherzig Sep 14, 2020
a4100a3
Updating readme for MySQL and PostgreSQL to include new flexible serv…
mjain2 Sep 15, 2020
6b69d6e
[NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (#10753)
audunn Sep 15, 2020
e354da0
Update workbooks api to include sourceId (#10781)
yves-chan Sep 15, 2020
dcf5f21
add alias for auto_rev_minor_version to fix az CLI linter error (#10789)
TylerLeonhardt Sep 15, 2020
4e73d15
Add new resource to Microsoft.Sql "ServerTrustGroup". (#10705)
dmitarredz Sep 15, 2020
32af5f5
Adding request body for listcredential for Microsoft.Kubernetes (#10766)
akashkeshari Sep 15, 2020
fbe9266
Update openapi-authoring-automated-guidelines.md (#10606)
jianyexi Sep 15, 2020
baa81a2
Add support for filter by deviceId (#10771)
liranc Sep 15, 2020
56d853a
Corrected Examples for Resource Mover to generate documentation examp…
ajaygit158 Sep 15, 2020
aa25f9e
Add new API version 2020-09-01 (#10737)
xingwu1 Sep 15, 2020
07f6986
Update keys.json (#10495)
jlichwa Sep 15, 2020
39466d2
Remove LiveVideoAnalytics Swagger and samples from Azure repo, as thi…
giakas Sep 15, 2020
560c551
Add Metrics Advisor API Properties. (#10722)
yangyuan Sep 16, 2020
8f7f2ce
[Microsoft.ApiManagement][2019-12-01] Content management resources: C…
azaslonov Sep 16, 2020
988270d
Update provisioningStatus field name for assignment (#10754)
abhinav-ghai Sep 16, 2020
7cf01c8
[ASR][V2A-RCM] Add new properties and provider specific models for V2…
imshashwataggarwal Sep 16, 2020
1b98adc
[Hub Generated] Review request for Microsoft.CostManagement to add ve…
paornela Sep 16, 2020
a79f3b3
Bump up version number for "old" preview api (#10768)
jorgbaca Sep 16, 2020
d199ce1
updated apispec (#10719)
tamilmani1989 Sep 16, 2020
942718d
added new api version (#10784)
jorgecotillo Sep 16, 2020
995320f
[Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.Hea…
shmartel Sep 16, 2020
8362798
[Synapse] - Unify dayofweek definition (#10449)
idear1203 Sep 16, 2020
0ac9e06
fix synapse readme for python (#10750)
wonner Sep 16, 2020
c71c7ee
Fix Python conf for AnomalyDectector (#10818)
lmazuel Sep 16, 2020
5325e13
Add CloudEvent and Custom Schema versions of the EventGrid Data-Plane…
ellismg Sep 16, 2020
f595fe8
Change enum value name for SupportedRuntimeVersion (#10824)
metacpp Sep 17, 2020
e342403
python codegen (#10826)
changlong-liu Sep 17, 2020
434f266
[Hub Generated] Review request for Microsoft.AlertsManagement to add …
orieldar Sep 17, 2020
2bb9298
Corrected case in operation ids (#10811)
audunn Sep 17, 2020
3aa6a51
Document IMDS version 2020-06-01 (#10426)
LittleBoxOfSunshine Sep 17, 2020
b0cc5a8
Adds base for updating Microsoft.HealthcareApis from version stable/2…
anrudraw Sep 17, 2020
c627c60
Updates readme
anrudraw Sep 17, 2020
1e3c4b5
Updates API version in new specs and examples
anrudraw Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/specification/analysisservices/ @taiwu
/specification/alertsmanagement/ @ofirmanor @olalavi @erangon @orieldar @ilaizi @shakednai1 @khaboasb @orenhor
/specification/apimanagement/ @promoisha @solankisamir
/specification/applicationinsights/ @alexeldeib
/specification/asazure/ @athipp
Expand Down
10 changes: 10 additions & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ closedlist
closedlists
Cloudamize
cloudapp
cloudevents
cloudproperties
cloudsimple
clustermonitoring
Expand Down Expand Up @@ -394,6 +395,7 @@ Databricks
datacatalog
Datacenter
datacenters
datacontenttype
datadisk
datafactory
datafactoryv
Expand All @@ -408,6 +410,7 @@ datamigration
datapoint
Dataset
datasets
dataschema
datasource
Datasources
datastore
Expand Down Expand Up @@ -477,6 +480,7 @@ discoverbackup
diskmigrationjobs
diskoperations
Distcp
Distro
DMTS
Dnat
dnsname
Expand All @@ -486,6 +490,8 @@ Domainful
domainname
domainservices
DOTALL
dras
DRAs
DRMs
dsmax
DTDL
Expand Down Expand Up @@ -583,6 +589,8 @@ fileservers
fileshare
Filestream
filesystems
fileuploaderr
fileuploadout
fileurl
findsimilars
findsquare
Expand Down Expand Up @@ -1471,6 +1479,7 @@ southindia
sparkconf
sparql
SPDX
specversion
SQLAG
sqldatabase
SQLDB
Expand Down Expand Up @@ -1631,6 +1640,7 @@ Turbonomic
Txns
Typeless
typeperf
UEFI
UEBA
Uint
uksouth
Expand Down
29 changes: 25 additions & 4 deletions documentation/openapi-authoring-automated-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ We request OpenAPI(Swagger) spec authoring be assigned to engineers who have an
| [R2007](#r2007) | [LongRunningOperationsWithLongRunningExtension](#r2007) | ARM OpenAPI(swagger) specs |
| [R2029](#r2029) | [PageableOperation](#r2029) | ARM and Data plane OpenAPI(swagger) specs |
| [R4006](#r4006) | [DeprecatedXmsCodeGenerationSetting](#r4006) | ARM and Data plane OpenAPI(swagger) specs |
| [R4024](#r4024) | [PreviewVersionOverOneYear](#r4024) | ARM OpenAPI(swagger) specs |


### RPaaS Violations
Expand Down Expand Up @@ -1432,7 +1433,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul

**Applies to** : ARM OpenAPI(swagger) specs

**Output Message**: Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, systemData. Model definition '{0}' has extra properties ['{1}'].
**Output Message**: Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, systemData, extendedlocation. Model definition '{0}' has extra properties ['{1}'].

**Description**: Per [ARM guidelines](https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md), top level properties of a resource should be only ones from the allowed set.

Expand Down Expand Up @@ -1690,7 +1691,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul
**Output Message**: Properties of a PATCH request body must not be {0}. PATCH operation: '{1}' Model Definition: '{2}' Property: '{3}'

**Description**: A request parameter of the Patch Operation must not have a required/default value.
But it's allowed when all required properties are marked as discriminator, because the discriminator must be required.
But it's allowed when the only required properties is marked as discriminator, because the discriminator must be required.

**CreatedAt** : N/A

Expand Down Expand Up @@ -1994,7 +1995,7 @@ Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rul

### <a name="r3021" ></a>R3021 PathResourceTypeNameCamelCase

**Category** : ARM Warning
**Category** : ARM Error

**Applies to** : ARM and Data Plane OpenAPI(swagger) specs

Expand Down Expand Up @@ -2948,4 +2949,24 @@ The following would be valid:
}
...
```
Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)
Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)

### <a name="r4024" ></a>R4024 PreviewVersionOverOneYear

**Category** : SDK Warning

**Applies to** : ARM OpenAPI(swagger) specs

**Output Message** : The API version:{api-version} having been in a preview state over one year , please move to GA or retire.

**Description** : Per [Retirement-of-Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews), service, feature, API, and SKU in preview for over one year need to move to GA or retire.

**CreatedAt**: Sep 8, 2020

**LastModifiedAt**: Sep 8, 2020

**How to fix the violation**:
Consider retiring or moving to GA.

Links: [Index](#index) | [Error vs. Warning](#error-vs-warning) | [Automated Rules](#automated-rules) | [ARM](#arm-violations): [Errors](#arm-errors) or [Warnings](#arm-warnings) | [SDK](#sdk-violations): [Errors](#sdk-errors) or [Warnings](#sdk-warnings)

Loading