Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update batch sdk comments #10517

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Update batch sdk comments #10517

merged 1 commit into from
Sep 11, 2020

Conversation

xingwu1
Copy link
Member

@xingwu1 xingwu1 commented Aug 19, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@xingwu1 xingwu1 requested a review from matthchr as a code owner August 19, 2020 04:18
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 19, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 19, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xingwu1
Copy link
Member Author

xingwu1 commented Aug 19, 2020

This is just pure comment update.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from a57424e with merge commit 4c0054d. SDK Automation 13.0.17.20200909.5
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/7851: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 16:57:07 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0508:73E2:D5FCB2:16ECAD5:5F5BAC61","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4783","x-ratelimit-reset":"1599845091","x-ratelimit-used":"217","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/batch_2020-03-01.11.0@10517","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ⚠️batch/2017-05-01.5.0 [View full logs
    No file is changed.
  • ⚠️batch/2018-03-01.6.1 [View full logs
    No file is changed.
  • ⚠️batch/2018-08-01.7.0 [View full logs
    No file is changed.
  • ⚠️batch/2018-12-01.8.0 [View full logs
    No file is changed.
  • ⚠️batch/2019-06-01.9.0 [View full logs
    No file is changed.
  • ⚠️batch/2019-08-01.10.0 [View full logs
    No file is changed.
  • ️✔️batch/2020-03-01.11.0 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 17:07:48 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0500:5C97:B40DA:12E58A:5F5BAEE4","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 19, 2020

azure-sdk-for-js - Release

failed [Logs] [Expand Details]
  • Generate from a57424e with merge commit 4c0054d. SDK Automation 13.0.17.20200909.5
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-js/pull/1697: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 16:55:26 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07D7:4303:885125:EEDFBE:5F5BABFD","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4899","x-ratelimit-reset":"1599845091","x-ratelimit-used":"101","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-js/git/refs/heads/sdkAutomation/@azure_batch@10517","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    [AutoRest] WARNING: HEAD 'getPropertiesFromTask' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getPropertiesFromComputeNode' method missing 404 status code section -- this might be unintentional.
  • @azure/batch [View full logs]  [Release SDK Changes]
      [npmPack] npm WARN deprecated rollup-plugin-commonjs@9.3.4: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-commonjs.
      [npmPack] npm WARN deprecated rollup-plugin-json@3.1.0: This module has been deprecated and is no longer maintained. Please use @rollup/plugin-json.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@3.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated jssha@2.4.2: jsSHA versions < 3.0.0 will no longer receive feature updates
      [npmPack] npm WARN deprecated rollup-plugin-inject@2.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] npm ERR! code ELIFECYCLE
      [npmPack] npm ERR! errno 2
      [npmPack] npm ERR! @azure/batch@7.0.0 build: `tsc && rollup -c rollup.config.js && npm run minify`
      [npmPack] npm ERR! Exit status 2
      [npmPack] npm ERR! 
      [npmPack] npm ERR! Failed at the @azure/batch@7.0.0 build script.
      [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      [npmPack] 
      [npmPack] npm ERR! A complete log of this run can be found in:
      [npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-09-11T16_57_20_409Z-debug.log
      [npmPack] npm ERR! code ELIFECYCLE
      [npmPack] npm ERR! errno 2
      [npmPack] npm ERR! @azure/batch@7.0.0 prepack: `npm install && npm run build`
      [npmPack] npm ERR! Exit status 2
      [npmPack] npm ERR! 
      [npmPack] npm ERR! Failed at the @azure/batch@7.0.0 prepack script.
      [npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      [npmPack] 
      [npmPack] npm ERR! A complete log of this run can be found in:
      [npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-09-11T16_57_20_420Z-debug.log
      Failed to create the package @azure/batch.
      Error: npm pack npm WARN deprecated rollup-plugin-commonjs@9.3.4: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-commonjs.
      npm WARN deprecated rollup-plugin-json@3.1.0: This module has been deprecated and is no longer maintained. Please use @rollup/plugin-json.
      npm WARN deprecated rollup-plugin-node-resolve@3.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      npm WARN deprecated jssha@2.4.2: jsSHA versions < 3.0.0 will no longer receive feature updates
      npm WARN deprecated rollup-plugin-inject@2.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
      npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      npm notice created a lockfile as package-lock.json. You should commit this file.
      npm ERR! code ELIFECYCLE
      npm ERR! errno 2
      npm ERR! @azure/batch@7.0.0 build: `tsc && rollup -c rollup.config.js && npm run minify`
      npm ERR! Exit status 2
      npm ERR! 
      npm ERR! Failed at the @azure/batch@7.0.0 build script.
      npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      

      npm ERR! A complete log of this run can be found in:
      npm ERR! /home/sdk/.npm/_logs/2020-09-11T16_57_20_409Z-debug.log
      npm ERR! code ELIFECYCLE
      npm ERR! errno 2
      npm ERR! @azure/batch@7.0.0 prepack: npm install && npm run build
      npm ERR! Exit status 2
      npm ERR!
      npm ERR! Failed at the @azure/batch@7.0.0 prepack script.
      npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

      npm ERR! A complete log of this run can be found in:
      npm ERR! /home/sdk/.npm/_logs/2020-09-11T16_57_20_420Z-debug.log
      , {}
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Fri, 11 Sep 2020 16:57:21 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0740:0EC7:7370D0:1077523:5F5BAC71","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 19, 2020

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 19, 2020

    azure-sdk-for-python - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 19, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 19, 2020

    azure-resource-manager-schemas - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 19, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @tjprescott
    Copy link
    Member

    @xingwu1, I can't merge this due to SpellCheck failing.

    @majastrz majastrz removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 2, 2020
    @majastrz
    Copy link
    Member

    majastrz commented Sep 2, 2020

    This does not require ARM review.

    @tjprescott
    Copy link
    Member

    Please check the CI failure.

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 8, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @xingwu1
    Copy link
    Member Author

    xingwu1 commented Sep 8, 2020

    @tjprescott , fix the spells check failure by adding work to custom-words.txt. However, the current CI failure is due to JS repo script issue, which has nothing related to my change.

    @xingwu1
    Copy link
    Member Author

    xingwu1 commented Sep 9, 2020

    @tjprescott, please merge it when you are available.

    @tjprescott tjprescott merged commit 4c0054d into Azure:master Sep 11, 2020
    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
    …into formrecognizer_regeneration
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits)
      Changes for new api version sdk generate (Azure#10685)
      Update batch sdk comments (Azure#10517)
      Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673)
      Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762)
      Spark Compute Isolation enabled (Azure#10726)
      [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677)
      PostgreSQL Flexible Server New API Swagger Changes (Azure#10586)
      Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760)
      Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752)
      modify description of properties to be self consistent (Azure#10711)
      Adding ComputeInstance to preview swagger (Azure#10654)
      remove unsupported reversproxy and useTestExtension (Azure#10728)
      Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735)
      FR v2.1-preview.1 update (Azure#10747)
      ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071)
      Eventhub: Added PrivateEndpointConnection API (Azure#10635)
      codegen onboard df for cli (Azure#8531)
      Update swagger for outbound public ip feature (Azure#10713)
      2020-09-01-hybrid profile for AzureStack (Azure#10295)
      Update pull_request_assignment.yml (Azure#10724)
      ...
    @xingwu1 xingwu1 deleted the master1 branch October 11, 2024 18:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants