Update CorrectedOpFlash attributes #147
Conversation
Updated angle unit from microseconds to degrees.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_10_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
There was a problem hiding this comment.
I am assuming that the upstream module filling sbn::CorrectedOpFlashTiming has been changed to fill values in nanoseconds rather than microseconds (or else, that the documentation was wrong about the times being in nanoseconds).
Asking to change the comment text if possible, the rest is good to the extent of my limited understanding of the matter (that is, I don't know where in the associations the removed information can be found... is it association metadata?).
| float deltaZ { fDefault }; ///< | Matched flash Z center - charge Z center | (cm) | ||
| float radius { fDefault }; ///< Hypotenuse of DeltaY and DeltaZ (cm) | ||
| float angle { fDefault }; ///< | Angle between charge PCA and light PCA | (us) | ||
| float angle { fDefault }; ///< | Angle between charge PCA and light PCA | (deg) |
There was a problem hiding this comment.
Should have been radians...
| float NuToFLight { fDefault }; ///< | Nu ToF using light only | (us) | ||
| float NuToFCharge { fDefault }; ///< | Nu ToF Z from tpc vertex | (us) |
There was a problem hiding this comment.
In the documentation, could you spell "time of flight" out? It may save some time to unaccustomed readers.
| float NuToFLight { fDefault }; ///< | Nu ToF using light only | (us) | |
| float NuToFCharge { fDefault }; ///< | Nu ToF Z from tpc vertex | (us) | |
| float NuToFLight { fDefault }; ///< | Nu time of flight using light only | (us) | |
| float NuToFCharge { fDefault }; ///< | Nu time of flight using Z from TPC vertex | (us) |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
Remove CorrectedOpFlash attributes that can be found via slice-correctedopflash assns. It also changes the attributes to reflect each of the corrections separately.
Merging this PR solves SBNSoftware/sbnanaobj#160 .
This PR is to be merged with
SBNSoftware/sbncode#584
SBNSoftware/sbnanaobj#162