- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33
Change CorrectedOpFlash attributed #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on the sbnanaobj PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, provided that the other changes are approved.
| trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01 SBNSoftware/sbnobj#147 SBNSoftware/sbnanaobj#162 | 
| ✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard | 
| ✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard | 
| ❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard | 
| ❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard | 
| ❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard | 
| ❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard | 
Description
Remove CorrectedOpFlash attributes that can be found via slice-correctedopflash assns. It also changes the attributes to reflect each of the corrections separately.
Merging this PR solves SBNSoftware/sbnanaobj#160 .
This PR is to be merged with
SBNSoftware/sbnanaobj#162
SBNSoftware/sbnobj#147