Skip to content

Feature/acastill lightpropagationfixes #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/acastill lightpropagationfixes #834

wants to merge 5 commits into from

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Sep 29, 2025 •
edited
Loading

Description

Remove CorrectedOpFlash attributes that can be found via slice-correctedopflash assns. It also changes the attributes to reflect each of the corrections separately.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

This PR is to be merged with
SBNSoftware/sbnanaobj#162
SBNSoftware/sbncode#584
SBNSoftware/sbnobj#147

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo self-assigned this Sep 29, 2025
@asanchezcastillo asanchezcastillo added the enhancement New feature or request label Sep 29, 2025
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Fall Production - Validation Sep 29, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production - Validation Oct 7, 2025
@linyan-w linyan-w moved this from Reviewer Approved to Waiting on Reviewer in SBND 2025 Fall Production - Validation Oct 7, 2025
@linyan-w linyan-w moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production - Validation Oct 8, 2025
@nathanielerowe
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

@fjnicolas Can you take a look at this?

@nathanielerowe
Copy link
Contributor

trigger build SBNSoftware/sbnanaobj#162 SBNSoftware/sbncode#584 SBNSoftware/sbnobj#147

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

trigger build SBNSoftware/sbnanaobj/#162 SBNSoftware/sbncode/#584 SBNSoftware/sbnobj/#147 LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

@asanchezcastillo It looks like the build error is actually related to your sbnanaobj PR. Please update the checksums!

6144: INFO: class 'caf::SRCorrectedOpFlash' has a different checksum for ClassVersion 13. Incrementing ClassVersion to 14 and assigning it to checksum 2247699110
6145: WARNING: classes_def.xml files have been updated: rebuild dictionaries.
6146: [1972/1975] Checking class versions for ROOT dictionary sbndcode_Decoders_PTB
6147: [1973/1975] Checking class versions for ROOT dictionary sbnobj_Common_Reco
6148: [1974/1975] Checking class versions for ROOT dictionary sbndcode_BlipRecoSBND_Utils
6149: [1975/1975] Checking class versions for ROOT dictionary sbndcode_SBNDCVN_module_helpers
6150: ninja: build stopped: subcommand failed.
6151: ```

@nathanielerowe nathanielerowe moved this from Reviewer Approved to Flagged by CI in SBND 2025 Fall Production - Validation Oct 22, 2025
@nathanielerowe
Copy link
Contributor

trigger build SBNSoftware/sbnanaobj#162 SBNSoftware/sbncode#584 SBNSoftware/sbnobj#147 LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linyan-w linyan-w linyan-w approved these changes

@fjnicolas fjnicolas fjnicolas approved these changes

Assignees

@asanchezcastillo asanchezcastillo

Labels

enhancement New feature or request

Projects

SBND 2025 Fall Production - Validation
Status: Flagged by CI

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asanchezcastillo @nathanielerowe @FNALbuild @linyan-w @fjnicolas