Skip to content

Conversation

@juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti requested a review from a team July 29, 2022 13:07
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #26413 (281bf13) into develop (6d4f021) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #26413   +/-   ##
========================================
  Coverage    38.90%   38.90%           
========================================
  Files          751      751           
  Lines        18797    18797           
  Branches      1413     1413           
========================================
  Hits          7313     7313           
  Misses       11266    11266           
  Partials       218      218           
Flag Coverage Δ
e2e 38.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...views/room/MessageList/lib/isMessageFirstUnread.ts 50.00% <0.00%> (-16.67%) ⬇️
apps/meteor/app/ui-utils/client/lib/openRoom.js 74.50% <0.00%> (-3.93%) ⬇️
apps/meteor/client/lib/meteorCallWrapper.ts 96.42% <0.00%> (-3.58%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 50.96% <0.00%> (-1.45%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 74.85% <0.00%> (-1.15%) ⬇️
apps/meteor/app/ui-login/client/login/form.js 73.20% <0.00%> (-0.66%) ⬇️
apps/meteor/client/hooks/useUpdateAvatar.ts 48.57% <0.00%> (ø)
apps/meteor/app/ui/client/views/app/room.js 49.79% <0.00%> (+0.20%) ⬆️
...nt/views/admin/settings/hooks/useSettingsGroups.ts 90.00% <0.00%> (+25.00%) ⬆️
...r/client/startup/notifications/usersNameChanged.ts 100.00% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ggazzo ggazzo marked this pull request as ready for review July 29, 2022 22:41
@ggazzo ggazzo requested a review from a team as a code owner July 29, 2022 22:41
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 29, 2022
@kodiakhq kodiakhq bot merged commit 1431f2e into develop Jul 29, 2022
@kodiakhq kodiakhq bot deleted the convert-client/views/account/security branch July 29, 2022 22:42
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants