Chore: validateParams to accept different validators per request method #26357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
commented
Jul 25, 2022
KevLehman
commented
Jul 26, 2022
KevLehman
commented
Jul 26, 2022
murtaza98
reviewed
Jul 29, 2022
murtaza98
pushed a commit
that referenced
this pull request
Jul 29, 2022
murtaza98
reviewed
Jul 29, 2022
murtaza98
previously requested changes
Jul 29, 2022
Contributor
murtaza98
left a comment
murtaza98
left a comment
There was a problem hiding this comment.
@KevLehman FYI: Left some suggestions over here -> #26410
Codecov Report
@@ Coverage Diff @@
## develop #26357 +/- ##
==========================================
Coverage ? 38.92%
==========================================
Files ? 751
Lines ? 18797
Branches ? 1413
==========================================
Hits ? 7317
Misses ? 11262
Partials ? 218
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
KevLehman
changed the title
ggazzo
added
stat: QA skipped
stat: ready to merge
ggazzo
approved these changes
Aug 1, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 2, 2022
…history * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) [IMPROVE] validateParams to accept different validators per request method (#26357) Regression: Fix spacing problem on AppStatus component (#26421) Chore: Convert client/views/account/security folder to ts (#26413) i18n: Makes the text less ambiguous (#20895) Chore: Missing some English translation keywords (#20131) Chore: Exclude private/public folders from typecheck (#26399) [NEW] Marketplace apps page new list view layout (#26181) Chore: Rewrite custom OAuth Modals to react (#26204) i18n: Manual sync from LingoHub (#26397) Chore: Options in BaseRaw model could possibly be undefined (#26395) [IMPROVE] Use single change stream to watch DB changes (#26336)
sampaiodiego
changed the title
carlosrodrigues94
pushed a commit
that referenced
this pull request
Aug 3, 2022
…ethod (#26357) Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 11, 2022
…ethod (#26357) Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments