Chore: Update text from Layout_Home_Body
#25711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusbsilva137
suggested changes
Jun 7, 2022
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
…t-homepage-content
matheusbsilva137
suggested changes
Jun 9, 2022
Contributor
There was a problem hiding this comment.
The changes applied to the Layout_Home_Body look fine. We still need to update the new Layout_Custom_Body setting, though
Maybe you could use Settings.getValueById('Layout_Home_Body') before updating the Layout_Home_Body setting's value so that you know if Layout_Custom_Body should be set to true or false.
gabriellsh
reviewed
Jun 13, 2022
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
BTW, you forgot to import the migration in the index :p. I'm testing it so I'll fix it.
… feat/change-default-homepage-content * 'new/homepage' of github.com:RocketChat/Rocket.Chat: (22 commits) [FIX] Client-generated sort parameters in channel directory (#25768) Chore: Add tests for agents screens (#25637) Chore: Notification Preferences to TS (#25827) Chore: Convert MemoizedSetting, Setting, Section (#25572) Regression: Fix users.create call (#25834) Chore: Add auto label and improve Kodiak configuration (#25829) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [NEW] Create header for new homepage (#25795) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) ...
gabriellsh
previously requested changes
Jun 13, 2022
matheusbsilva137
approved these changes
Jun 14, 2022
gabriellsh
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Update
Layout_Home_Bodydefault text and addblockedfield in itIssue(s)
Steps to test or reproduce
Further comments