Skip to content

[FIX] Bug on starting Jitsi video calls , multiple messages#16601

Merged
ggazzo merged 2 commits intodevelopfrom
fix/jitsi
Feb 14, 2020
Merged

[FIX] Bug on starting Jitsi video calls , multiple messages#16601
ggazzo merged 2 commits intodevelopfrom
fix/jitsi

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 14, 2020

closes #12148
closes #14508

@ggazzo ggazzo added the area: ui Touches the code on client side label Feb 14, 2020
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@ggazzo ggazzo changed the title [FIX] Autorepeat on starting video calls Jitsi [FIX] Bug on starting Jitsi video calls , multiple messages Feb 14, 2020
@ggazzo ggazzo merged commit 5c2b7b3 into develop Feb 14, 2020
@ggazzo ggazzo deleted the fix/jitsi branch February 14, 2020 16:56
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
gabriellsh added a commit that referenced this pull request Feb 18, 2020
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat: (90 commits)
  [FIX] livechat/rooms endpoint not working with big amount of livechats (#16623)
  [FIX] Regression: Jitsi on external window infinite loop (#16625)
  [FIX] UiKit not updating new actionIds received as responses from actions (#16624)
  Bump version to 3.1.0-develop
  Bump version to 3.0.0
  Bump version to 3.0.0-rc.11
  Fix enter behavior
  send file on enter
  Fix github actions accessing the github registry (#16521)
  Bump version to 3.0.0-rc.10
  [FIX] Bug on starting Jitsi video calls , multiple messages (#16601)
  Bump version to 3.0.0-rc.9
  Regression: fix read unread messages (#16562)
  Regression: UIKit update modal actions (#16570)
  fixed duplicated toastrs (#16578)
  Update Livechat widget dependency version to 1.3.1. (#16580)
  Update Apps-Engine version (#16584)
  [FIX] Error when successfully joining room by invite link (#16571)
  Add breaking notice regarding TLS (#16575)
  [FIX] Invite links proxy URLs not working when using CDN (#16581)
  ...
const { jitsiTimeout } = Rooms.findOne({ _id: rid }, { fields: { jitsiTimeout: 1 }, reactive: false });

if (jitsiTimeout && (new Date() - new Date(jitsiTimeout) + CONSTANTS.TIMEOUT < CONSTANTS.DEBOUNCE)) {
if (jitsiTimeout && (TimeSync.serverTime(), - new Date(jitsiTimeout) + CONSTANTS.TIMEOUT < CONSTANTS.DEBOUNCE)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if there's a bug somewhere in the interface that keeps triggering new Jitsi Video calls, we've now not fixed that issue but slowed it down?

I'm automatically creating a new Jitsi video call every morning apparently and I have no idea why. Unsure about the RocketChat version we're running though, will have to ask about that.

@MetahumanFamily
Copy link

Issue still persisting. Rocket.Chat v 3.0.10. Jitsi is latest build as of today.

@luixxiul
Copy link

luixxiul commented May 1, 2020

Issue still persisting.

Do you mean this issue exactly? #12148

@MetahumanFamily
Copy link

Issue still persisting.

Do you mean this issue exactly? #12148

Correct.

@luixxiul
Copy link

luixxiul commented May 1, 2020

I think you would like to follow the issue over there as there seems to be another case: #12148 (comment)

@grimuz
Copy link

grimuz commented Jul 7, 2020

Same problem on:
Server: Rocket Chat 3.3.0
Client: Desktop App 2.17.9 (Windows)

@cremfert
Copy link

Same here, tries to start video conference repeatingly when MacBook is in standby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jitsi : multiple invitation Autorepeat on starting video calls

7 participants