Skip to content

[FIX] Bug on starting Jitsi video calls , multiple messages #16601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
Feb 14, 2020
Merged

[FIX] Bug on starting Jitsi video calls , multiple messages #16601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9f1b0
fix multiple call
ggazzo Feb 14, 2020
39993fb
Update app/videobridge/client/views/videoFlexTab.js
ggazzo Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/videobridge/client/views/videoFlexTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Meteor } from 'meteor/meteor';
import { Session } from 'meteor/session';
import { Template } from 'meteor/templating';
import { TimeSync } from 'meteor/mizzao:timesync';

import { settings } from '../../../settings';
import { modal, TabBar } from '../../../ui-utils';
Expand Down Expand Up @@ -59,7 +60,7 @@ Template.videoFlexTab.onRendered(function() {
const update = () => {
const { jitsiTimeout } = Rooms.findOne({ _id: rid }, { fields: { jitsiTimeout: 1 }, reactive: false });

if (jitsiTimeout && (new Date() - new Date(jitsiTimeout) + CONSTANTS.TIMEOUT < CONSTANTS.DEBOUNCE)) {
if (jitsiTimeout && (TimeSync.serverTime(), - new Date(jitsiTimeout) + CONSTANTS.TIMEOUT < CONSTANTS.DEBOUNCE)) {
Copy link

@Bjeaurn Bjeaurn Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if there's a bug somewhere in the interface that keeps triggering new Jitsi Video calls, we've now not fixed that issue but slowed it down?

I'm automatically creating a new Jitsi video call every morning apparently and I have no idea why. Unsure about the RocketChat version we're running though, will have to ask about that.

return;
}
if (Meteor.status().connected) {
Expand Down