[FIX] Regression: Jitsi on external window infinite loop#16625
Merged
sampaiodiego merged 2 commits intodevelopfrom Feb 18, 2020
Merged
[FIX] Regression: Jitsi on external window infinite loop#16625sampaiodiego merged 2 commits intodevelopfrom
sampaiodiego merged 2 commits intodevelopfrom
Conversation
sampaiodiego
requested changes
Feb 17, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
I guess the other call to start() needs to wrap be wrapped in a nonreactive call as well, right?
https://github.com/RocketChat/Rocket.Chat/pull/16625/files#diff-6056610957cb6ad7c1d79a04eb6fc424R161
sampaiodiego
approved these changes
Feb 18, 2020
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Feb 18, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: (90 commits) [FIX] livechat/rooms endpoint not working with big amount of livechats (#16623) [FIX] Regression: Jitsi on external window infinite loop (#16625) [FIX] UiKit not updating new actionIds received as responses from actions (#16624) Bump version to 3.1.0-develop Bump version to 3.0.0 Bump version to 3.0.0-rc.11 Fix enter behavior send file on enter Fix github actions accessing the github registry (#16521) Bump version to 3.0.0-rc.10 [FIX] Bug on starting Jitsi video calls , multiple messages (#16601) Bump version to 3.0.0-rc.9 Regression: fix read unread messages (#16562) Regression: UIKit update modal actions (#16570) fixed duplicated toastrs (#16578) Update Livechat widget dependency version to 1.3.1. (#16580) Update Apps-Engine version (#16584) [FIX] Error when successfully joining room by invite link (#16571) Add breaking notice regarding TLS (#16575) [FIX] Invite links proxy URLs not working when using CDN (#16581) ...
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 19, 2020
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 19, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.