Skip to content

[NEW] Check the Omnichannel service status per Department#16425

Merged
renatobecker merged 2 commits intodevelopfrom
omnichannel/check-service-status-per-department
Feb 3, 2020
Merged

[NEW] Check the Omnichannel service status per Department#16425
renatobecker merged 2 commits intodevelopfrom
omnichannel/check-service-status-per-department

Conversation

@renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Feb 3, 2020 •
edited
Loading

This PR allows checking the Omnichannel service status(online/offline) per Department.
Currently, the Livechat.online() method doesn't allow to pass any department to check the status of the service, so it's possible to start a new conversation associated with a specific Department that has no online agents, which provides a very bad user experience.

This change will also have an impact on Apps-Engine, we need to change it to be able to check the status of the Omnichannel service through an App too.

In addition: I have created an issue on the Apps-Engine repo, describing this case.

@renatobecker renatobecker added this to the 3.0.0 milestone Feb 3, 2020
@claassistantio
Copy link

claassistantio commented Feb 3, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ renatobecker
❌ lolimay
You have signed the CLA already but the status is still pending? Let us recheck it.

@renatobecker renatobecker mentioned this pull request Feb 3, 2020
Closed
@shiqimei shiqimei mentioned this pull request Feb 3, 2020
Merged
@shiqimei
Copy link
Contributor

shiqimei commented Feb 3, 2020 •
edited
Loading

Hi! @renatobecker I've modified the bridge method and created a PR on apps-engine side. Let me know if there is something to improve, thanks!

@sampaiodiego sampaiodiego added the documentation: needed Needs addition/changes to documentation label Feb 3, 2020
sampaiodiego
sampaiodiego approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatobecker can you please update the documentation?

@renatobecker
Copy link
Contributor Author

renatobecker commented Feb 3, 2020

@renatobecker can you please update the documentation?

@sampaiodiego, sure thing!

@renatobecker renatobecker merged commit 1c9441c into develop Feb 3, 2020
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
8fc703e 
…exact_search

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
f0ca4b6 
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ui-k…
4acb4e2 
…it.2.0-turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
sampaiodiego pushed a commit that referenced this pull request Feb 3, 2020
@renatobecker @shiqimei @sampaiodiego
[NEW] Check the Omnichannel service status per Department (#16425)
7607269 
* Allow to check the service status per department.

* update livechat bridge method isOnline

Co-authored-by: Shiqi Mei <shiqi.mei@lolimay.cn>
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
6663679 
…readmessages

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
568f048 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  ...
@rodrigok rodrigok deleted the omnichannel/check-service-status-per-department branch February 4, 2020 00:52
d-gubert pushed a commit that referenced this pull request Feb 4, 2020
@renatobecker @shiqimei @d-gubert
[NEW] Check the Omnichannel service status per Department (#16425)
7e7a6f2 
* Allow to check the service status per department.

* update livechat bridge method isOnline

Co-authored-by: Shiqi Mei <shiqi.mei@lolimay.cn>
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
03fe860 
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  fix group
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  fix group messages
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'ui-kit.2.0-turbo' of github.com:RocketChat/Rocket.Chat …
c4ec872 
…into ui-kit.2.0-turbo

* 'ui-kit.2.0-turbo' of github.com:RocketChat/Rocket.Chat:
  Remove npm
  Update with error messages
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  fix close modals
  Update action trigger format
  typo
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

No one assigned

Labels

documentation: needed Needs addition/changes to documentation

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@renatobecker @claassistantio @shiqimei @sampaiodiego