feat: add taskbar icon blinking for new message notifications

[Ram-sah19]

Adds taskbar icon blinking when a new message notification is received.

This improves visibility of unread messages when the application window is minimized or not focused.

Implementation:

• Uses the existing notification system
• Triggers attention drawing on new messages
• Stops blinking once the notification is cleared

Summary by CodeRabbit

• Bug Fixes
  • Improved notification attention handling to trigger visual flashing for both text and voice notifications.
  • Enhanced consistency in notification close and dismissal behaviors to reliably manage attention states across all notification types.

[coderabbitai]

Walkthrough

The notification handling logic in src/notifications/main.ts is simplified to consistently manage attention states across all notification types. Previously, attention triggering and stopping were conditional on notification type; now the behavior is uniform, with show/close/dismissal handlers managing attention regardless of type.

Changes

Cohort / File(s)	Summary
Notification Attention Logic src/notifications/main.ts	Modified flash and attention-stop logic in show, close, and dismissal handlers to apply consistently across notification types (text and voice) rather than conditionally based on type.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

type: feature

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding taskbar icon blinking for notifications, which aligns with the PR objectives and the code modifications in src/notifications/main.ts that adjust attention-triggering logic for notifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/notifications/main.ts`:
- Around line 90-92: The current logic always calls
attentionDrawing.drawAttention because handleCreateEvent is defaulting missing
notificationType to 'text'; stop defaulting the type and only call drawAttention
for explicit chat message types. Update handleCreateEvent to preserve undefined
types (remove or change the default-to-'text' behavior) and change the attention
check around attentionDrawing.drawAttention to require an explicit
notificationType of 'text' or 'voice' (e.g., ensure
notification.notificationType === 'text' || notification.notificationType ===
'voice') and that the notification represents a new chat message before invoking
drawAttention.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4d27765f-7c12-4c18-9a18-cf64031cdb64

📥 Commits

Reviewing files that changed from the base of the PR and between 49261f5 and 85ee1ac.

📒 Files selected for processing (1)

• src/notifications/main.ts

📜 Review details

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use TypeScript strict mode enabled in TypeScript configuration
Use React functional components with hooks instead of class components
Follow FSA (Flux Standard Action) pattern for Redux actions
Use camelCase for file names and PascalCase for component file names
All code must pass ESLint and TypeScript checks
Write self-documenting code with clear naming; avoid unnecessary comments except for complex business logic or non-obvious decisions
Use Fuselage components from @rocket.chat/fuselage for all UI work and only create custom components when Fuselage doesn't provide what's needed
Check Theme.d.ts for valid color tokens when using Fuselage components
Use defensive coding with optional chaining and fallbacks for Linux-only APIs (process.getuid(), process.getgid(), process.geteuid(), process.getegid()) to ensure cross-platform compatibility across Windows, macOS, and Linux

Files:

• src/notifications/main.ts

🔇 Additional comments (2)

src/notifications/main.ts (2)

104-105: Unconditional stop on close looks safe.

stopAttention() already ignores untracked IDs and keeps attention active while other tracked notifications remain, so removing the type guard here is fine.

---

250-251: Dismissal cleanup is consistent with the close path.

Calling stopAttention() here is safe even if close() already triggered the listener, because the helper is idempotent for untracked IDs.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

This will blink for every notification, not just new messages.

handleCreateEvent defaults missing notificationType values to 'text' on Line 226, and the type only allows 'text' | 'voice'. In practice this condition is always true for created notifications, so downloads/server notifications will also call drawAttention(). That is broader than the PR objective.

Suggested fix

-    const notificationType = notificationTypes.get(id);
-
-    // Only flash for chat-related notifications
-    if (notificationType === 'text' || notificationType === 'voice') {
+    const notificationType = notificationTypes.get(id);
+    if (notificationType !== undefined) {
       attentionDrawing.drawAttention(id);
     }

Also avoid defaulting missing types to 'text' when the notification is created:

-  notificationTypes.set(id, options.notificationType || 'text');
+  if (options.notificationType) {
+    notificationTypes.set(id, options.notificationType);
+  }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/notifications/main.ts` around lines 90 - 92, The current logic always
calls attentionDrawing.drawAttention because handleCreateEvent is defaulting
missing notificationType to 'text'; stop defaulting the type and only call
drawAttention for explicit chat message types. Update handleCreateEvent to
preserve undefined types (remove or change the default-to-'text' behavior) and
change the attention check around attentionDrawing.drawAttention to require an
explicit notificationType of 'text' or 'voice' (e.g., ensure
notification.notificationType === 'text' || notification.notificationType ===
'voice') and that the notification represents a new chat message before invoking
drawAttention.