Skip to content

fix: Zoom client launch regression in video call windows#3046

Merged
jeanfbrito merged 2 commits intomasterfrom
fix-zoom-app
Jun 30, 2025
Merged

fix: Zoom client launch regression in video call windows#3046
jeanfbrito merged 2 commits intomasterfrom
fix-zoom-app

Conversation

@jeanfbrito
Copy link
Copy Markdown
Member

Problem

A regression in v4.5.0 prevents external applications (like Zoom) from launching when users click "Launch Meeting" in video calls. The issue was introduced in PR #2935 where a global will-navigate handler was intercepting all navigation attempts, including external protocol links like zoommtg://.

Solution

  • Fixed document viewer handler: Added context checks to only intercept navigation for actual PDF viewers, not video call windows
  • Enhanced video call window: Added proper external protocol handling with setWindowOpenHandler and will-navigate handlers
  • Added protocol permissions: Enabled openExternal permission for video call windows

Changes

  • src/documentViewer/ipc.ts: Skip interception for video call windows and external protocols
  • src/videoCallWindow/ipc.ts: Add comprehensive external protocol support

Testing

  • ✅ Linting and build pass
  • ✅ Zoom protocol links should now launch external client
  • ✅ PDF viewer functionality remains intact
  • ✅ Other external protocols (Teams, etc.) work as expected

Impact

  • Fixes: Zoom/Teams/external app launches from video calls
  • Maintains: All existing PDF viewer and external link functionality
  • Improves: Overall external protocol handling in video call windows

https://rocketchat.atlassian.net/browse/SUP-815

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Windows installer download

@github-actions
Copy link
Copy Markdown

macOS installer download

@jeanfbrito jeanfbrito merged commit df65589 into master Jun 30, 2025
10 checks passed
@jeanfbrito jeanfbrito deleted the fix-zoom-app branch June 30, 2025 16:49
sreeja2007 pushed a commit to sreeja2007/Rocket.Chat.Electron that referenced this pull request Mar 2, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant