chore: Add flip fuses to all the builds#3052
Merged
jeanfbrito merged 1 commit intomasterfrom Jul 3, 2025
Merged
Conversation
sreeja2007
pushed a commit
to sreeja2007/Rocket.Chat.Electron
that referenced
this pull request
Mar 2, 2026
Ram-sah19
pushed a commit
to Ram-sah19/Rocket.Chat.Electron
that referenced
this pull request
Mar 10, 2026
Ram-sah19
pushed a commit
to Ram-sah19/Rocket.Chat.Electron
that referenced
this pull request
Mar 10, 2026
Ram-sah19
pushed a commit
to Ram-sah19/Rocket.Chat.Electron
that referenced
this pull request
Mar 10, 2026
Ram-sah19
pushed a commit
to Ram-sah19/Rocket.Chat.Electron
that referenced
this pull request
Mar 10, 2026
Ram-sah19
pushed a commit
to Ram-sah19/Rocket.Chat.Electron
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the special handling that was skipping electron fuses for Mac App Store (MAS) builds and now applies security fuses consistently across all platforms including MAS.
Changes Made
darwinandmasbuilds receive the same security fusesBackground
Previously, the build process was skipping electron fuses for MAS builds under the assumption that "App Store has its own integrity validation." However, electron fuses provide additional security benefits that are compatible with and complementary to App Store validation:
EnableEmbeddedAsarIntegrityValidation: Validates app.asar content integrityOnlyLoadAppFromAsar: Prevents loading code from outside the ASAR archiveBenefits
This change brings our MAS builds in line with modern Electron security best practices while maintaining compatibility with App Store requirements.