Skip to content

chore: Add flip fuses to all the builds#3052

Merged
jeanfbrito merged 1 commit intomasterfrom
flag
Jul 3, 2025
Merged

chore: Add flip fuses to all the builds#3052
jeanfbrito merged 1 commit intomasterfrom
flag

Conversation

@jeanfbrito
Copy link
Copy Markdown
Member

@jeanfbrito jeanfbrito commented Jul 3, 2025

This PR removes the special handling that was skipping electron fuses for Mac App Store (MAS) builds and now applies security fuses consistently across all platforms including MAS.

Changes Made

  • Removed MAS skip logic: Eliminated the conditional check that was bypassing fuse application for MAS builds
  • Unified platform handling: Now both darwin and mas builds receive the same security fuses
  • Improved code structure: Replaced if-else chain with a cleaner switch statement for better maintainability
  • Consistent security posture: All macOS builds (regular and MAS) now have the same security enhancements

Background

Previously, the build process was skipping electron fuses for MAS builds under the assumption that "App Store has its own integrity validation." However, electron fuses provide additional security benefits that are compatible with and complementary to App Store validation:

  • EnableEmbeddedAsarIntegrityValidation: Validates app.asar content integrity
  • OnlyLoadAppFromAsar: Prevents loading code from outside the ASAR archive
  • And other security-focused fuses

Benefits

  • Enhanced Security: MAS builds now receive the same security hardening as other builds
  • Consistency: Uniform security configuration across all distribution channels
  • Future-proof: Aligned with current best practices for Electron app security

This change brings our MAS builds in line with modern Electron security best practices while maintaining compatibility with App Store requirements.

@jeanfbrito jeanfbrito merged commit 25542d5 into master Jul 3, 2025
8 checks passed
@jeanfbrito jeanfbrito deleted the flag branch July 3, 2025 20:14
sreeja2007 pushed a commit to sreeja2007/Rocket.Chat.Electron that referenced this pull request Mar 2, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Ram-sah19 pushed a commit to Ram-sah19/Rocket.Chat.Electron that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant