identity V3: public facing changes #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
reviewed
Feb 4, 2021
| @@ -594,6 +599,10 @@ class Purchases @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) intern | |||
| * @param newAppUserID The new appUserID that should be linked to the currently user | |||
| * @param [listener] An optional listener to listen for successes or errors. | |||
| */ | |||
| @Deprecated( | |||
| "Use logIn instead", | |||
| ReplaceWith("logIn") | |||
There was a problem hiding this comment.
You can add the parameters of the logIn function that way the developers get a nice automatic "replace with" option in Android Studio. Maybe it works just specifying the function name, but I don't think so...
There was a problem hiding this comment.
nice, didn't know that was a thing, will do!
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
4 times, most recently
from
058c692 to
87f4326
Compare
aboedo
force-pushed
the
feature/identityv3
branch
from
58dfa2c to
44b1592
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
5 times, most recently
from
a31fcad to
eb51693
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
eb51693 to
e1b78b9
Compare
aboedo
force-pushed
the
feature/identityv3
branch
from
5f16f25 to
e48287e
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
2 times, most recently
from
b67fc51 to
36955a8
Compare
vegaro
approved these changes
Feb 19, 2021
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
a305e82 to
63f02c5
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
3 times, most recently
from
651cff1 to
326111e
Compare
aboedo
force-pushed
the
fix/identify_endpoint_path
branch
from
c512dc2 to
7f3d26a
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
3 times, most recently
from
fbdf391 to
4d51fbf
Compare
aboedo
force-pushed
the
fix/identify_endpoint_path
branch
from
878a0d7 to
0037287
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
4d51fbf to
117e87b
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
2 times, most recently
from
c755a01 to
718a178
Compare
aboedo
changed the base branch from
develop
to
identityv3_update_appuserid_location_in_identify
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
718a178 to
88b1a39
Compare
aboedo
force-pushed
the
identityv3_update_appuserid_location_in_identify
branch
from
9e56ba3 to
234f0a0
Compare
Base automatically changed from
identityv3_update_appuserid_location_in_identify
to
develop
March 22, 2021 20:04
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
88b1a39 to
6cbd194
Compare
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
6cbd194 to
d95e100
Compare
vegaro
requested changes
May 3, 2021
| @@ -796,7 +805,7 @@ class Purchases @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) intern | |||
| */ | |||
| @JvmOverloads | |||
| @JvmSynthetic | |||
There was a problem hiding this comment.
This annotation and the one in line 764 should be removed, otherwise it would still be hidden in Java. We add it because internal functions are public in Java, since internal is a Kotlin keyword.
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
d95e100 to
2015cd6
Compare
Closed
aboedo
force-pushed
the
feature/identityv3_public_facing_changes
branch
from
2015cd6 to
73feee3
Compare
beylmk
reviewed
Jul 15, 2021
| @@ -348,7 +348,7 @@ internal fun Purchases.logInWith( | |||
| * @param [onError] Will be called after the call has completed with an error. | |||
| */ | |||
| @Suppress("unused") | |||
| internal fun Purchases.logOutWith( | |||
| fun Purchases.logOutWith( | |||
There was a problem hiding this comment.
just curious, does this return the newly-created anonymous user's purchaser info?
There was a problem hiding this comment.
it deletes all data for the current user, then generates a new anonymous id, and returns the purchaserinfo for that new anonymous id
beylmk
approved these changes
Jul 15, 2021
vegaro
approved these changes
Jul 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
logInandlogOutpublic, deprecates identity v2 methods.Requirements: